Relicense CUDA Bindings and CUDA Python under Apache 2.0#2293
Conversation
Signed-off-by: Keith Kraus <[email protected]>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Keith Kraus <[email protected]>
|
/ok to test |
|
|
codex found this: Tracked lockfiles still contain old cuda-bindings license metadata, e.g. cuda_bindings/pixi.lock:3035 and cuda_core/pixi.lock:4497. They are excluded from SPDX checks and partly describe old solved/released packages, but they will still show up in repo-wide old-license searches. |
Signed-off-by: Keith Kraus <[email protected]>
I raised issue #2298 after seeing this. Not sure if we want to do anything about it, but I thought it's useful to document clearly what we have at the moment. |
|
@kkraus14 this branch is out-of-date with main. Do you want to re-trigger the CI with main merged? |
Does it matter? I think the only non-comment changes are related to some packaging flows with regards to metadata. I don't think we'd gain any more signal vs the green CI we already have? |
I wasn't sure. When I posted the comment, the CI had just triggered, i.e. it was just the right moment to update; but I didn't want to click the Update branch button without asking. I agree it's fine to merge without updating now that the CI is finished already. One small worry: is @mdboom's cybind MR 453 complete and ready for merging as well? — When I ran codex a couple hours ago, it reported that the cython-gen (aka legacy) updates still only came from 452. |
|
I just noticed, this PR updates the license in all release notes, e.g. In the meantime codex told me that MR 453 also takes care of the cython-gen / legacy changes, but it also found an potential issue that I'll report on the MR. |
rwgk
left a comment
There was a problem hiding this comment.
To be sure there is no drift, please don't merge before:
-
cybind MR 454 was merged.
-
The new cybind main was run against this PR.
|
I ran a local SPDX copyright-year audit over the tracked files, comparing the newest year in each NVIDIA The full audit currently reports 53 mismatch files in the repository. I then intersected those mismatch files with the files changed by this PR, using PR head 86561aa against refreshed Result: PR 2293 changes 260 files, and none of them overlap with the 53 copyright-year mismatch files. (I backed up my script as |
There was a problem hiding this comment.
This pulled in a bunch of unintended and out of scope changes for this PR. Should we split this out into a different PR?
There was a problem hiding this comment.
That would leave cuda-python out-of-sync with cybind main.
All tests are passing, therefore I think it's better to accept that cybind moved ahead while we worked on this.
What
Dependency
This draft is based on the post-PR-2285 main branch and is blocked on the internal cybind MR.
Validation