refactor: codec-owned provider-surface detection via a built-in registry#301
Conversation
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe PR adds registry-backed surface descriptors for OpenAI Chat, OpenAI Responses, and Anthropic Messages, routes request/response normalization through the registry, and adds tests for hint-aware request detection. ChangesRegistry-backed codec surface detection
Estimated review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
size:M
zhongxuanwang-nv
added
the
DO NOT MERGE
zhongxuanwang-nv
force-pushed
the
refactor/relay-362-codec-surface-registry
branch
from
7060394 to
a881241
Compare
zhongxuanwang-nv
force-pushed
the
refactor/relay-362-codec-surface-registry
branch
from
a881241 to
005d547
Compare
zhongxuanwang-nv
force-pushed
the
refactor/relay-362-codec-surface-registry
branch
from
005d547 to
8d45d8d
Compare
Move provider-surface detection out of the hard-coded if/else chains in codec::resolve into codec-owned SurfaceDescriptors iterated through a small built-in registry. resolve.rs is now provider-agnostic (no field-name literals); each built-in codec owns its detection and decode logic in a SURFACE_DESCRIPTOR const. Add detect_request_surface_with_hint(body, Option<&str>); detect_request_surface delegates to it with None for exact parity. A recognized provider hint can upgrade the ambiguous messages-only shape (the Anthropic detector claims it for provider "anthropic"), while registry priority order keeps it from overriding a strong input/instructions/system signal. The hint is not wired into adaptive, so behavior is preserved and all existing codec::resolve tests pass unchanged. Relates to RELAY-362 Signed-off-by: Zhongxuan Wang <[email protected]>
zhongxuanwang-nv
force-pushed
the
refactor/relay-362-codec-surface-registry
branch
from
8d45d8d to
261fc7e
Compare
zhongxuanwang-nv
removed
the
DO NOT MERGE
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/core/src/codec/resolve.rs`:
- Around line 82-106: The exact-one response descriptor selection rule is
duplicated between detect_response_surface and normalize_response, so extract
that matching logic into a single private helper and have both functions use it.
Keep the helper responsible for iterating REGISTRY and returning the sole
matching descriptor only when there is exactly one match, then reuse it in both
detect_response_surface and normalize_response so any future change to matching
behavior stays consistent.
In `@crates/core/tests/unit/codec/resolve_tests.rs`:
- Around line 269-289: Add a response-side unit test for the “exactly one match”
behavior in detect_response_surface/normalize_response: create cases where a
response body matches zero detectors and where it matches two or more detectors,
and assert the result is None. Place the test near
hint_never_overrides_strong_signals so the new contract is covered alongside the
existing resolve_tests helpers and detector logic.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 3bb781d9-a210-4683-bd6e-49bb1898f05d
📒 Files selected for processing (5)
crates/core/src/codec/anthropic.rscrates/core/src/codec/openai_chat.rscrates/core/src/codec/openai_responses.rscrates/core/src/codec/resolve.rscrates/core/tests/unit/codec/resolve_tests.rs
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: Check / Run
- GitHub Check: Preview docs
🧰 Additional context used
📓 Path-based instructions (14)
**/*.rs
📄 CodeRabbit inference engine (.agents/skills/add-binding-feature/SKILL.md)
Use
snake_casenaming convention for Rust identifiers (e.g.,nemo_relay_tool_call)
**/*.rs: Any Rust change must runjust test-rust
Any Rust change must runcargo fmt --all
Any Rust change must runcargo clippy --workspace --all-targets -- -D warnings
**/*.rs: Runcargo fmt --allfor all FFI work since it is Rust work
Runjust test-rustto validate FFI changes
Runcargo clippy --workspace --all-targets -- -D warningsto enforce strict linting on FFI workWhen Rust files changed as part of Go work, also run
cargo fmt --all,just test-rust, andcargo clippy --workspace --all-targets -- -D warnings
**/*.rs: Runcargo fmt --allwhen Rust files are changed as part of Node work
Runcargo clippy --workspace --all-targets -- -D warningswhen Rust files are changed as part of Node work
Runjust test-rustwhen Rust files are changed as part of Node work
**/*.rs: Runcargo fmt --allto format all Rust code
Runcargo clippy --workspace --all-targets -- -D warningsto enforce all clippy lints as errors
**/*.rs: Runcargo fmt --allwhen Rust files changed as part of WebAssembly work
Runcargo clippy --workspace --all-targets -- -D warningswhen Rust files changed as part of WebAssembly work
**/*.rs: If any Rust code changed, always runjust test-rust
If any Rust code changed, also runcargo fmt --all
If any Rust code changed, also runcargo clippy --workspace --all-targets -- -D warnings
Run Rust formatting withcargo fmt --all
Run Rust linting withcargo clippy --workspace --all-targets -- -D warnings
**/*.rs: Usecargo fmtfor Rust code formatting
Runcargo clippy -- -D warningsto lint Rust code and treat all warnings as errors
Use Rust snake_case naming convention for Rust identifiers
Include SPDX license header in all Rust source files using double-slash comment syntax
Validate Rust code withuv run pre-commit run --all-filesto enforce cargo fmt formatting check, cargo clippy lints, and cargo deny aud...
Files:
crates/core/src/codec/openai_responses.rscrates/core/src/codec/openai_chat.rscrates/core/tests/unit/codec/resolve_tests.rscrates/core/src/codec/resolve.rscrates/core/src/codec/anthropic.rs
**/{Cargo.toml,**/*.rs}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Maintain consistency between Rust package names in
Cargo.tomland their actual usage across the codebase
Files:
crates/core/src/codec/openai_responses.rscrates/core/src/codec/openai_chat.rscrates/core/tests/unit/codec/resolve_tests.rscrates/core/src/codec/resolve.rscrates/core/src/codec/anthropic.rs
**/*.{h,hpp,c,cpp,rs}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Ensure FFI header and library naming follows consistent conventions across platform-specific builds
Files:
crates/core/src/codec/openai_responses.rscrates/core/src/codec/openai_chat.rscrates/core/tests/unit/codec/resolve_tests.rscrates/core/src/codec/resolve.rscrates/core/src/codec/anthropic.rs
{crates/core,crates/adaptive}/**/*
📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)
Changes to
crates/coreorcrates/adaptivemust run the full language matrix
Files:
crates/core/src/codec/openai_responses.rscrates/core/src/codec/openai_chat.rscrates/core/tests/unit/codec/resolve_tests.rscrates/core/src/codec/resolve.rscrates/core/src/codec/anthropic.rs
**/*.{rs,toml}
📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)
Update Rust crate names and module prefixes during coordinated rename operations
Files:
crates/core/src/codec/openai_responses.rscrates/core/src/codec/openai_chat.rscrates/core/tests/unit/codec/resolve_tests.rscrates/core/src/codec/resolve.rscrates/core/src/codec/anthropic.rs
crates/core/**/*.rs
📄 CodeRabbit inference engine (.agents/skills/test-go-binding/SKILL.md)
If the change touched
crates/coreor shared runtime semantics, also usevalidate-changefor broader validation
crates/core/**/*.rs: UseJson = serde_json::Valuein Rust-facing runtime APIs where the existing code expects JSON payloads.
UseResult<T>withFlowErrorin core runtime paths. Keep errors explicit and binding-appropriate at the wrapper layer.
Files:
crates/core/src/codec/openai_responses.rscrates/core/src/codec/openai_chat.rscrates/core/tests/unit/codec/resolve_tests.rscrates/core/src/codec/resolve.rscrates/core/src/codec/anthropic.rs
crates/{core,adaptive}/**
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
If
crates/coreorcrates/adaptivechanged, run the full matrix across Rust, Python, Go, Node.js, and WebAssembly
Files:
crates/core/src/codec/openai_responses.rscrates/core/src/codec/openai_chat.rscrates/core/tests/unit/codec/resolve_tests.rscrates/core/src/codec/resolve.rscrates/core/src/codec/anthropic.rs
**/*.{rs,py,js,ts,tsx,jsx,go,sh,toml,yaml,yml,md}
📄 CodeRabbit inference engine (AGENTS.md)
Keep SPDX headers on source, docs, scripts, and configuration files. The project is Apache-2.0.
Files:
crates/core/src/codec/openai_responses.rscrates/core/src/codec/openai_chat.rscrates/core/tests/unit/codec/resolve_tests.rscrates/core/src/codec/resolve.rscrates/core/src/codec/anthropic.rs
**/*.{rs,py,go,js,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Follow binding naming conventions: Rust and Python use
snake_case, C FFI exports prefixednemo_relay_, Go usesPascalCasefor public APIs, Node.js usescamelCase.
Files:
crates/core/src/codec/openai_responses.rscrates/core/src/codec/openai_chat.rscrates/core/tests/unit/codec/resolve_tests.rscrates/core/src/codec/resolve.rscrates/core/src/codec/anthropic.rs
crates/**/*.rs
📄 CodeRabbit inference engine (AGENTS.md)
crates/**/*.rs: Keep async behavior on the existing tokio-based model. Bindings should preserve callback and future lifetimes rather than blocking or hiding async work unexpectedly.
UseJson = serde_json::Valuein Rust-facing runtime APIs for JSON payload handling.
Files:
crates/core/src/codec/openai_responses.rscrates/core/src/codec/openai_chat.rscrates/core/tests/unit/codec/resolve_tests.rscrates/core/src/codec/resolve.rscrates/core/src/codec/anthropic.rs
**
⚙️ CodeRabbit configuration file
**:AGENTS.md
This file provides guidance to agents, including Claude Code and OpenAI Codex, when working in this repository.
Project Overview
NeMo Relay is a multi-language agent runtime framework for execution scopes, lifecycle events, middleware, plugins, and observability around tool and LLM calls. The core runtime is Rust. Primary supported bindings are Rust, Python, and Node.js. Go, WebAssembly, and the raw C FFI are experimental and source-first.
The shared runtime model is:
- Scope stacks decide where work belongs and which scope-local behavior is visible.
- Middleware registries decide what guardrails and intercepts run around managed calls.
- Plugins install reusable runtime behavior from configuration.
- Events record runtime behavior in ATOF form.
- Subscribers and exporters consume events in-process or export them to ATIF, OpenTelemetry, OpenInference, or other backends.
Repository Structure
The repository layout separates the Rust runtime, language bindings, documentation,
integration patches, and agent-facing skills.crates/ core/ # Rust core runtime crate, published as nemo-relay adaptive/ # Adaptive runtime primitives and plugin components python/ # PyO3 native extension for the Python package ffi/ # Raw C ABI layer used by downstream bindings such as Go node/ # NAPI Node.js binding and JavaScript/TypeScript entry points wasm/ # wasm-bindgen WebAssembly binding and JS wrappers python/ nemo_relay/ # Python wrapper package: scopes, tools, LLM, middleware, typed helpers, plugins, adaptive helpers tests/ # Python tests go/ nemo_relay/ # Experimental Go CGo binding and tests fern/ # Fern documentation site scripts/ # Stable wrappers and helper scripts; build/test/docs entry points live in justfile third_party/ # P...
Files:
crates/core/src/codec/openai_responses.rscrates/core/src/codec/openai_chat.rscrates/core/tests/unit/codec/resolve_tests.rscrates/core/src/codec/resolve.rscrates/core/src/codec/anthropic.rs
crates/{core,adaptive}/**/*.rs
⚙️ CodeRabbit configuration file
crates/{core,adaptive}/**/*.rs: Review the Rust runtime for async correctness, scope isolation, middleware ordering, and event lifecycle regressions.
Pay close attention to task-local/thread-local scope propagation, callback lifetimes, stream finalization, and root_uuid isolation.
Public API changes should preserve existing behavior unless tests and docs show the intended migration path.
Files:
crates/core/src/codec/openai_responses.rscrates/core/src/codec/openai_chat.rscrates/core/tests/unit/codec/resolve_tests.rscrates/core/src/codec/resolve.rscrates/core/src/codec/anthropic.rs
{crates/adaptive/**/*.rs,**/*test*.{rs,py,go,ts,js},**/*adaptive*test*.{rs,py,go,ts,js},docs/plugins/adaptive/**}
📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Maintain documented and tested validation and report behavior for adaptive surfaces
Files:
crates/core/tests/unit/codec/resolve_tests.rs
{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}
⚙️ CodeRabbit configuration file
{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}: Tests should cover the behavior promised by the changed API surface, including error paths and cross-request isolation where relevant.
Prefer assertions on lifecycle events, scope stacks, middleware ordering, and binding parity over shallow smoke tests.
Files:
crates/core/tests/unit/codec/resolve_tests.rs
🔇 Additional comments (6)
crates/core/src/codec/resolve.rs (2)
27-48: LGTM!
58-73: LGTM!crates/core/src/codec/openai_responses.rs (1)
46-55: LGTM!crates/core/src/codec/anthropic.rs (1)
47-60: LGTM!crates/core/src/codec/openai_chat.rs (1)
34-40: LGTM!crates/core/tests/unit/codec/resolve_tests.rs (1)
226-301: LGTM!
| let mut matches = REGISTRY.iter().filter(|d| (d.detect_response)(obj)); | ||
| match (matches.next(), matches.next()) { | ||
| (Some(descriptor), None) => Some(descriptor.surface), | ||
| _ => None, | ||
| } | ||
| } | ||
|
|
||
| /// Best-effort decode of a raw request into [`AnnotatedLlmRequest`] (fail-open). | ||
| #[must_use] | ||
| pub fn normalize_request(request: &LlmRequest) -> Option<AnnotatedLlmRequest> { | ||
| match detect_request_surface(&request.content)? { | ||
| ProviderSurface::OpenAIChat => OpenAIChatCodec.decode(request), | ||
| ProviderSurface::OpenAIResponses => OpenAIResponsesCodec.decode(request), | ||
| ProviderSurface::AnthropicMessages => AnthropicMessagesCodec.decode(request), | ||
| } | ||
| .ok() | ||
| let obj = request.content.as_object()?; | ||
| let descriptor = REGISTRY.iter().find(|d| (d.detect_request)(obj, None))?; | ||
| (descriptor.decode_request)(request).ok() | ||
| } | ||
|
|
||
| /// Best-effort decode of a raw response into [`AnnotatedLlmResponse`] (fail-open). | ||
| #[must_use] | ||
| pub fn normalize_response(raw: &Json) -> Option<AnnotatedLlmResponse> { | ||
| match detect_response_surface(raw)? { | ||
| ProviderSurface::OpenAIChat => OpenAIChatCodec.decode_response(raw), | ||
| ProviderSurface::OpenAIResponses => OpenAIResponsesCodec.decode_response(raw), | ||
| ProviderSurface::AnthropicMessages => AnthropicMessagesCodec.decode_response(raw), | ||
| } | ||
| .ok() | ||
| let obj = raw.as_object()?; | ||
| let mut matches = REGISTRY.iter().filter(|d| (d.detect_response)(obj)); | ||
| let descriptor = match (matches.next(), matches.next()) { | ||
| (Some(descriptor), None) => descriptor, | ||
| _ => return None, | ||
| }; | ||
| (descriptor.decode_response)(raw).ok() |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
De-duplicate the "exactly one matching response descriptor" rule.
detect_response_surface (Lines 82-87) and normalize_response (Lines 101-106) independently re-implement the same matches.next(), matches.next() exactly-one selection. If one is later changed (e.g., to first-match), detection and normalization will silently disagree on which surface a response belongs to. Extract a single private helper and have both call it.
♻️ Proposed helper to keep the rule in one place
+fn unique_response_descriptor(obj: &serde_json::Map<String, Json>) -> Option<&'static SurfaceDescriptor> {
+ let mut matches = REGISTRY.iter().filter(|d| (d.detect_response)(obj));
+ match (matches.next(), matches.next()) {
+ (Some(descriptor), None) => Some(descriptor),
+ _ => None,
+ }
+}
+
pub fn detect_response_surface(raw: &Json) -> Option<ProviderSurface> {
let obj = raw.as_object()?;
- let mut matches = REGISTRY.iter().filter(|d| (d.detect_response)(obj));
- match (matches.next(), matches.next()) {
- (Some(descriptor), None) => Some(descriptor.surface),
- _ => None,
- }
+ unique_response_descriptor(obj).map(|d| d.surface)
}
#[must_use]
pub fn normalize_response(raw: &Json) -> Option<AnnotatedLlmResponse> {
let obj = raw.as_object()?;
- let mut matches = REGISTRY.iter().filter(|d| (d.detect_response)(obj));
- let descriptor = match (matches.next(), matches.next()) {
- (Some(descriptor), None) => descriptor,
- _ => return None,
- };
+ let descriptor = unique_response_descriptor(obj)?;
(descriptor.decode_response)(raw).ok()
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| let mut matches = REGISTRY.iter().filter(|d| (d.detect_response)(obj)); | |
| match (matches.next(), matches.next()) { | |
| (Some(descriptor), None) => Some(descriptor.surface), | |
| _ => None, | |
| } | |
| } | |
| /// Best-effort decode of a raw request into [`AnnotatedLlmRequest`] (fail-open). | |
| #[must_use] | |
| pub fn normalize_request(request: &LlmRequest) -> Option<AnnotatedLlmRequest> { | |
| match detect_request_surface(&request.content)? { | |
| ProviderSurface::OpenAIChat => OpenAIChatCodec.decode(request), | |
| ProviderSurface::OpenAIResponses => OpenAIResponsesCodec.decode(request), | |
| ProviderSurface::AnthropicMessages => AnthropicMessagesCodec.decode(request), | |
| } | |
| .ok() | |
| let obj = request.content.as_object()?; | |
| let descriptor = REGISTRY.iter().find(|d| (d.detect_request)(obj, None))?; | |
| (descriptor.decode_request)(request).ok() | |
| } | |
| /// Best-effort decode of a raw response into [`AnnotatedLlmResponse`] (fail-open). | |
| #[must_use] | |
| pub fn normalize_response(raw: &Json) -> Option<AnnotatedLlmResponse> { | |
| match detect_response_surface(raw)? { | |
| ProviderSurface::OpenAIChat => OpenAIChatCodec.decode_response(raw), | |
| ProviderSurface::OpenAIResponses => OpenAIResponsesCodec.decode_response(raw), | |
| ProviderSurface::AnthropicMessages => AnthropicMessagesCodec.decode_response(raw), | |
| } | |
| .ok() | |
| let obj = raw.as_object()?; | |
| let mut matches = REGISTRY.iter().filter(|d| (d.detect_response)(obj)); | |
| let descriptor = match (matches.next(), matches.next()) { | |
| (Some(descriptor), None) => descriptor, | |
| _ => return None, | |
| }; | |
| (descriptor.decode_response)(raw).ok() | |
| fn unique_response_descriptor(obj: &serde_json::Map<String, Json>) -> Option<&'static SurfaceDescriptor> { | |
| let mut matches = REGISTRY.iter().filter(|d| (d.detect_response)(obj)); | |
| match (matches.next(), matches.next()) { | |
| (Some(descriptor), None) => Some(descriptor), | |
| _ => None, | |
| } | |
| } | |
| pub fn detect_response_surface(raw: &Json) -> Option<ProviderSurface> { | |
| let obj = raw.as_object()?; | |
| unique_response_descriptor(obj).map(|d| d.surface) | |
| } | |
| /// Best-effort decode of a raw request into [`AnnotatedLlmRequest`] (fail-open). | |
| #[must_use] | |
| pub fn normalize_request(request: &LlmRequest) -> Option<AnnotatedLlmRequest> { | |
| let obj = request.content.as_object()?; | |
| let descriptor = REGISTRY.iter().find(|d| (d.detect_request)(obj, None))?; | |
| (descriptor.decode_request)(request).ok() | |
| } | |
| /// Best-effort decode of a raw response into [`AnnotatedLlmResponse`] (fail-open). | |
| #[must_use] | |
| pub fn normalize_response(raw: &Json) -> Option<AnnotatedLlmResponse> { | |
| let obj = raw.as_object()?; | |
| let descriptor = unique_response_descriptor(obj)?; | |
| (descriptor.decode_response)(raw).ok() | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@crates/core/src/codec/resolve.rs` around lines 82 - 106, The exact-one
response descriptor selection rule is duplicated between detect_response_surface
and normalize_response, so extract that matching logic into a single private
helper and have both functions use it. Keep the helper responsible for iterating
REGISTRY and returning the sole matching descriptor only when there is exactly
one match, then reuse it in both detect_response_surface and normalize_response
so any future change to matching behavior stays consistent.
1 participant
Overview
Implements RELAY-362, the follow-up requested in review of #291: move provider-surface detection out of the hard-coded
if/elsechains incodec::resolveinto codec-owned descriptors iterated through a small built-in registry.resolve.rsis now provider-agnostic (no provider field-name literals), new built-in surfaces become additive, and a codec-owned provider hint can disambiguate the one ambiguous request shape (an Anthropic request without a top-levelsystem). The change is additive, Rust-core-only, and behavior-preserving: every existingcodec::resolvetest passes unchanged and the adaptive path is untouched.Details
codec::resolve— added apub(crate) SurfaceDescriptor(a hint-aware request detector, a response detector, and decode entry points) and a by-valuestatic REGISTRYordered by request-detection priority (Responses > Anthropic > Chat). The public functions are now provider-agnostic policy only: first registry match for requests, unique match for responses, fail-opennormalize_*.ProviderSurfaceand every existing public signature are unchanged.pub fn detect_request_surface_with_hint(body, Option<&str>)—detect_request_surfacedelegates to it withNonefor exact parity. A recognized hint can only upgrade the ambiguousmessages-only shape; registry priority order keeps it from overriding a stronginput/instructions/systemsignal.openai_chat,openai_responses,anthropic) owns its detectors (as closures) and decode entry points in aSURFACE_DESCRIPTORconst. Only Anthropic's request detector is hint-aware (it claims a system-lessmessagesbody when the hint is"anthropic"); the OpenAI detectors ignore the hint. Adding a future built-in surface (e.g. Gemini) means registering a descriptor, not editing detection logic.resolve_request_surface/build_semantic_request_viewwould change ACG pass-through behavior, so it is intentionally left to a separate follow-up. The shape-only ACG path and its source-guard test are untouched.Nonehint, the Anthropic upgrade, "never overrides a strong signal", non-object input); the existing detection/normalization tests are unchanged.No breaking changes. Local validation:
cargo test -p nemo-relay,-p nemo-relay-adaptive, and-p nemo-relay-pii-redactionpass;cargo clippy -p nemo-relay --all-features --all-targets,cargo fmt --check, andcargo doc -p nemo-relayare clean for the changed files. The full cross-language matrix is left to CI (no binding surfacescodec::resolve).Where should the reviewer start?
crates/core/src/codec/resolve.rs— theSurfaceDescriptor+REGISTRYand the detection-policy functions (detect_request_surface_with_hint,detect_response_surface). Then the per-codecSURFACE_DESCRIPTORblocks, especiallyanthropic.rs's hint-awaredetect_request: registry priority order (Responses before Anthropic) is what keeps the"anthropic"hint from overriding a stronginput/instructionssignal.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
New Features
Bug Fixes