Detect fused experts using _apply_gate as activation marker#1703
Open
Mapika wants to merge 1 commit into
Open
Conversation
_is_fused_experts_module() required an act_fn attribute, so fused expert modules that implement their gated activation as a method instead — e.g. MiniMaxM3VLExperts, whose clamped swiglu lives in _apply_gate() — were silently left unquantized (PTQ completes, experts stay high-precision). Accept _apply_gate as an alternative activation marker. The eager forward of such modules still performs the same two F.linear calls per expert that _QuantFusedExperts intercepts, so no other change is needed. Signed-off-by: Mapika <[email protected]>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR extends the fused-HuggingFace MoE expert detection helper to recognize expert containers that implement gate fusion via an ChangesFused-expert detection expansion
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix
Overview:
_is_fused_experts_module()requires anact_fnattribute, so fused expert modules that implement their gated activation as a method instead — e.g. transformers'MiniMaxM3VLExperts, whose GPT-OSS-style clamped swiglu lives in_apply_gate()— are silently left unquantized: PTQ completes without error, but all experts stay high-precision. This PR accepts_apply_gateas an alternative activation marker. The eager forward of such modules still performs the same twoF.linearcalls per expert that_QuantFusedExpertsintercepts, so detection is the only change needed.Testing
test_module_with_apply_gate_detectedintests/unit/torch/quantization/plugins/test_fused_experts.py; fullTestIsFusedExpertsModulesuite passes.Additional notes
Docstring of
_is_fused_experts_moduleupdated; no new dependencies.Summary by CodeRabbit
Bug Fixes
Tests