refactor(experiments): remove deprecated /experiments URL aliases#850
Merged
Conversation
The child endpoints moved from /experiments to /evaluations; the old /experiments... paths were registered as hidden aliases (include_in_schema=False) for backwards compatibility. Remove them now that callers have migrated. - intake: drop the alias-registration loop + unused APIRoute import; update the README example and remove the two URL-alias tests - nemo-insights: migrate the testbed ingest client (the only runtime consumer) to /evaluations - auth: remove the 4 stale /experiments blocks from static-authz.yaml and the dedicated PDP alias test Deprecated field aliases (experiment_id query param; experiment_name / parent_experiment_id / experiment_count response fields) are intentionally left in place — removing those requires an SDK regen and is a separate change. Verified: ruff clean; intake CRUD (34) + auth PDP (73) + nemo-insights (15) tests pass; opa policy suite 236/236. No SDK/OpenAPI regen needed (aliases were include_in_schema=False / x-not-in-openapi). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Signed-off-by: shanaiabuggy <[email protected]>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe Intake API removes hidden ChangesIntake evaluations route transition
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
|
BrianNewsom
approved these changes
Jul 24, 2026
shanaiabuggy
enabled auto-merge
July 24, 2026 21:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The intake evaluation endpoints moved from
/experimentsto/evaluations. The old/experiments…paths were kept as hidden aliases (include_in_schema=False) for backwards compatibility, with a matching set of hand-added entries in the auth bundle. Now that callers have migrated, this removes the temporary alias layer (the code literally carried a "TEMPORARY — remove in a follow-up PR" note).What
Removing the deprecated
/experiments…URLs required touching everything that produced, consumed, or authorized them:APIRouteimport; update the README curl example; remove the two URL-alias tests./experiments) to/evaluations, plus its test./experimentsendpoint blocks fromstatic-authz.yaml, and the dedicated PDP alias test.Scope note
Only the deprecated URLs are removed. The deprecated field aliases (
experiment_idquery param;experiment_name/parent_experiment_id/experiment_countresponse fields) are intentionally left in place — removing those changes the OpenAPI schema and requires an SDK regen, so it belongs in a separate PR.Validation
/experimentsintake consumers remain repo-wide.ruffclean;tyclean on changed files.include_in_schema=False/x-not-in-openapi, so they were never in the generated spec.🤖 Generated with Claude Code
Summary by CodeRabbit
/experimentsroutes with the canonical/evaluationsroutes for experiment/evaluation operations./evaluations./evaluationsrollup endpoint./experimentsback-compat routes./experimentsrouting and authorization.