feat(intake): add payload previews to telemetry lists#725
Merged
BrianNewsom merged 3 commits intoJul 16, 2026
Conversation
Signed-off-by: Brian Newsom <[email protected]>
Contributor
📝 WalkthroughWalkthroughIntake APIs now support ChangesMode contracts and text shaping
Evaluation session payload flow
Span and trace payload flow
Studio preview tables
Sequence Diagram(s)sequenceDiagram
participant Studio
participant IntakeAPI
participant ClickHouse
Studio->>IntakeAPI: Request spans or traces with mode=preview
IntakeAPI->>ClickHouse: Select bounded payloads and preview rollups
ClickHouse-->>IntakeAPI: Return 300-character payload fields
IntakeAPI-->>Studio: Render mode-shaped response
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@services/intake/tests/test_spans_clickhouse_repository.py`:
- Around line 152-154: Update the detailed-mode SQL assertions in the relevant
test to match the aliases emitted by _span_select_columns(mode="detailed"),
checking for “input AS input, output AS output” rather than the absent “input,
output” substring. Preserve the existing assertions that substringUTF8(input)
and payload_char_limit are not used.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 15093c4d-e3da-43f9-bfb7-64b3e1f68347
📒 Files selected for processing (32)
openapi/ga/individual/platform.openapi.yamlopenapi/ga/openapi.yamlopenapi/openapi.yamlservices/intake/src/nmp/intake/api/v2/experiments/endpoints.pyservices/intake/src/nmp/intake/api/v2/experiments/schemas.pyservices/intake/src/nmp/intake/spans/api/spans.pyservices/intake/src/nmp/intake/spans/api/spans_schemas.pyservices/intake/src/nmp/intake/spans/api/traces.pyservices/intake/src/nmp/intake/spans/api/traces_schemas.pyservices/intake/src/nmp/intake/spans/domain.pyservices/intake/src/nmp/intake/spans/evaluation_session_repository.pyservices/intake/src/nmp/intake/spans/service.pyservices/intake/src/nmp/intake/spans/span_repository.pyservices/intake/src/nmp/intake/spans/storage.pyservices/intake/src/nmp/intake/spans/trace_repository.pyservices/intake/tests/integration/spans/test_chat_completions_ingest.pyservices/intake/tests/integration/spans/test_experiment_sessions.pyservices/intake/tests/integration/spans/test_traces_read.pyservices/intake/tests/test_evaluation_session_clickhouse_repository.pyservices/intake/tests/test_experiment_session_schemas.pyservices/intake/tests/test_spans_clickhouse_repository.pyservices/intake/tests/test_spans_schemas.pyservices/intake/tests/test_spans_storage.pyservices/intake/tests/test_traces_clickhouse_repository.pyweb/packages/studio/src/components/IntakeLists/IntakePayloadPreviewCell.tsxweb/packages/studio/src/components/IntakeLists/IntakeSpansTable.test.tsxweb/packages/studio/src/components/IntakeLists/IntakeSpansTable.tsxweb/packages/studio/src/components/IntakeLists/IntakeTracesTable.test.tsxweb/packages/studio/src/components/IntakeLists/IntakeTracesTable.tsxweb/packages/studio/src/components/dataViews/EvaluationSessionsDataView/index.test.tsxweb/packages/studio/src/components/dataViews/EvaluationSessionsDataView/index.tsxweb/packages/studio/src/mocks/intake/telemetry.ts
Contributor
|
Signed-off-by: Brian Newsom <[email protected]>
shanaiabuggy
approved these changes
Jul 16, 2026
Signed-off-by: Brian Newsom <[email protected]>
BrianNewsom
enabled auto-merge
July 16, 2026 17:48
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@openapi/ga/individual/platform.openapi.yaml`:
- Line 4433: Restore the trace-list.mode default to detailed in all three
affected specs: openapi/ga/individual/platform.openapi.yaml:4433-4433,
openapi/ga/openapi.yaml:4433-4433, and openapi/openapi.yaml:4433-4433. Do not
introduce the preview default without a versioned breaking change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 641b6009-ebea-48b1-9309-6e2e4b14350f
⛔ Files ignored due to path filters (1)
sdk/python/nemo-platform/.nmpcontext/openapi.yamlis excluded by!sdk/**
📒 Files selected for processing (5)
openapi/ga/individual/platform.openapi.yamlopenapi/ga/openapi.yamlopenapi/openapi.yamlservices/intake/src/nmp/intake/spans/api/traces.pyservices/intake/tests/integration/spans/test_traces_read.py
🚧 Files skipped from review as they are similar to previous changes (2)
- services/intake/src/nmp/intake/spans/api/traces.py
- services/intake/tests/integration/spans/test_traces_read.py
BrianNewsom
disabled auto-merge
July 16, 2026 17:53
BrianNewsom
enabled auto-merge
July 16, 2026 17:53
BrianNewsom
deleted the
brnewsom/ase-169-show-inputoutput-on-tracesspans-table
branch
July 16, 2026 18:24
soluwalana
pushed a commit
that referenced
this pull request
Jul 17, 2026
* feat(intake): add payload previews to telemetry lists Signed-off-by: Brian Newsom <[email protected]> * chore: lint fixes Signed-off-by: Brian Newsom <[email protected]> * fix(intake): change default trace mode to preview Signed-off-by: Brian Newsom <[email protected]> --------- Signed-off-by: Brian Newsom <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
previewresponse mode for evaluation sessions, spans, and traces.previewreturns input/output previews truncated to 300 characters (spans include 1000-char error-message truncation);summaryomits these fields;detailedreturns full payloads.previewand includes rollups plus span-count for this mode.modeparameter and schema field semantics; expandedpreviewbehavior across endpoints.preview.