fix(studio): drop removed SpanEvaluationContext fields to fix Web typecheck#642
Merged
marcusds merged 1 commit intoJul 10, 2026
Merged
Conversation
The generated SpanEvaluationContext type only exposes evaluation_id and test_case_id, but intakeTelemetry.ts and spanKeyValues.test.tsx still referenced evaluation_run_id, evaluation_sha, and metadata, breaking the Web typecheck CI job. Signed-off-by: mschwab <[email protected]>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChangesEvaluation context handling
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
steramae-nvidia
approved these changes
Jul 10, 2026
Contributor
|
marcusds
deleted the
fix-studio-span-evaluation-context-typecheck/mschwab
branch
July 10, 2026 21:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
CI / Web typecheckjob is red: the generated SDK typeSpanEvaluationContextonly exposesevaluation_idandtest_case_id, but Studio code still references three fields that were removed from the schema —evaluation_run_id,evaluation_sha, andmetadata.Changes
src/util/intakeTelemetry.ts— drop the stale field refs fromgetEvaluationContextSummaryandhasEvaluationContext; keepevaluation_id/test_case_id.src/components/IntakeDetail/IntakeComponents/spanKeyValues.test.tsx—evaluation_context: { metadata: {} }→{}(still exercises the empty-context path).Verification
pnpm --filter nemo-studio-ui typecheck(tsc) — cleanpnpm --filter nemo-studio-ui typecheck:go(tsgo, CI/pre-push variant) — cleanpnpm --filter nemo-studio-ui test src/components/IntakeDetail/IntakeComponents/spanKeyValues.test.tsx— 7/7 passNote:
packages/sdk/generated/is gitignored and regenerated in CI, so if the API is later changed to re-add these fields, the consumers can be restored instead.Summary by CodeRabbit