Skip to content

docs(intake): Initial pass at intake documentation#560

Closed
BrianNewsom wants to merge 2 commits into
mainfrom
brnewsom/ase-449-initial-documentation-pass
Closed

docs(intake): Initial pass at intake documentation#560
BrianNewsom wants to merge 2 commits into
mainfrom
brnewsom/ase-449-initial-documentation-pass

Conversation

@BrianNewsom

@BrianNewsom BrianNewsom commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Introduced nemo-intake, an Intake experience for ingesting and reviewing agent telemetry (traces, spans, annotations, evaluator results).
    • Updated skill routing to send trace/telemetry requests to Intake.
    • Added new Intake documentation, including end-to-end setup, ingest/query workflows, and Studio access instructions.
  • Bug Fixes

    • Improved Intake startup behavior and guidance when ClickHouse is unavailable.
    • Updated local/test ClickHouse defaults to the latest supported version and aligned container naming.
  • Tests

    • Refreshed Intake-related integration tests for the updated ClickHouse setup.

@BrianNewsom
BrianNewsom requested review from a team as code owners July 2, 2026 22:21
@github-actions github-actions Bot added the docs label Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d4dc0a81-076b-4bf5-ba7e-79b7ed9dd2b1

📥 Commits

Reviewing files that changed from the base of the PR and between 07bc851 and 28311d5.

📒 Files selected for processing (1)
  • packages/nemo_platform_ext/src/nemo_platform_ext/skills/nemo-skill-selection/SKILL.md

📝 Walkthrough

Walkthrough

Adds the nemo-intake skill, routing, docs, and nav entry, plus updates agent skill lists. Separately renames the ClickHouse container, adds a legacy-container guard, and bumps ClickHouse to 26.3 in scripts and tests.

Changes

Intake skill, docs, and infra

Layer / File(s) Summary
nemo-intake skill definition and tests
packages/nemo_platform_ext/.../nemo-intake/SKILL.md, packages/nemo_platform_ext/.../nemo-intake/tests.json, packages/nemo_platform_ext/.../nemo-skill-selection/SKILL.md
Defines nemo-intake, adds routing tests, and maps trace/telemetry intents to it in the skill selector.
Intake documentation pages and nav
docs/intake/index.mdx, docs/intake/getting-started.mdx, docs/fern/gated-nav.yml, AGENTS.md, CLAUDE.md
Adds Intake docs, wires them into navigation, and lists nemo-intake in the available-skills docs.
ClickHouse container rename and version bump
services/intake/scripts/spans/run_clickhouse.sh, services/intake/tests/integration/spans/conftest.py, plugins/nemo-evaluator/tests/integration/test_publish_to_intake.py
Renames the ClickHouse container, adds a legacy-container startup guard, bumps the image to 26.3, and updates test cleanup/fixtures.

Possibly related PRs

Suggested labels: feat

Suggested reviewers: arpitsardhana

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title clearly matches the main change: an initial documentation pass for Intake.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch brnewsom/ase-449-initial-documentation-pass

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@packages/nemo_platform_ext/src/nemo_platform_ext/skills/nemo-skill-selection/SKILL.md`:
- Line 55: Update the `nemo-intake` row in `SKILL.md` to include explicit
read-only telemetry query phrases such as “query my spans” and “show me spans”
alongside the existing trace and annotation intents. Keep the wording aligned
with the `nemo-intake` skill’s purpose so the selector matches span/trace lookup
requests before they fall through to disambiguation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6d5f0d7f-64b1-4b48-bcaf-c114a2ab285d

📥 Commits

Reviewing files that changed from the base of the PR and between e0e6920 and 07bc851.

📒 Files selected for processing (11)
  • AGENTS.md
  • CLAUDE.md
  • docs/fern/gated-nav.yml
  • docs/intake/getting-started.mdx
  • docs/intake/index.mdx
  • packages/nemo_platform_ext/src/nemo_platform_ext/skills/nemo-intake/SKILL.md
  • packages/nemo_platform_ext/src/nemo_platform_ext/skills/nemo-intake/tests.json
  • packages/nemo_platform_ext/src/nemo_platform_ext/skills/nemo-skill-selection/SKILL.md
  • plugins/nemo-evaluator/tests/integration/test_publish_to_intake.py
  • services/intake/scripts/spans/run_clickhouse.sh
  • services/intake/tests/integration/spans/conftest.py

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 22515/29649 75.9% 60.8%
Integration Tests 13015/28329 45.9% 19.4%

@BrianNewsom BrianNewsom closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants