Skip to content

fix: correct return type annotation of get_nsys_entrypoint #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewwhitecdw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct return type annotation of get_nsys_entrypoint #568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nemo_run/core/execution/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def get_launcher_prefix(self) -> Optional[list[str]]:
os.makedirs(os.path.join(self.job_dir, launcher.nsys_folder), exist_ok=True)
return launcher.get_nsys_prefix(profile_dir=self.job_dir)

def get_nsys_entrypoint(self) -> str:
def get_nsys_entrypoint(self) -> tuple[str, str]:
return ("nsys", "")

def supports_launcher_transform(self) -> bool:
Expand Down