Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nemo_run/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ def _construct_args(
for name, parameter in params.items():
arg = kwargs.get(name, None)

if arg:
if arg is not None:
if dataclasses.is_dataclass(arg):
final_args[name] = fdl.cast(
Config,
Expand Down
11 changes: 11 additions & 0 deletions test/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ def train_manual(
return optim


def with_falsy_values(count: int = 1, flag: bool = True, label: str = "x"):
return count, flag, label


@dataclass
class Data:
name: str
Expand Down Expand Up @@ -222,6 +226,13 @@ def test_default_optional(self, train_func):

assert fn() == fdl.build(optimizer())

def test_falsy_primitive_args_are_preserved(self):
"""Falsy primitive values like 0, False, and '' must not be dropped."""
partial = run.Partial(with_falsy_values, count=0, flag=False, label="")
fn = fdl.build(partial)

assert fn() == (0, False, "")

def test_clone(self):
partial = run.Partial(train, model=dummy_model(), optim=optimizer())
clone = partial.clone()
Expand Down