Skip to content

fix: use title in Experiment.from_title not found message #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewwhitecdw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use title in Experiment.from_title not found message #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nemo_run/run/experiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ def from_title(
parent_dir = os.path.join(get_nemorun_home(), "experiments", title)
exp_dir = _get_latest_dir(parent_dir)

assert os.path.isdir(exp_dir), f"Experiment {id} not found."
assert os.path.isdir(exp_dir), f"Experiment {title} not found."

exp = cls._from_config(exp_dir)
return exp
Expand Down
2 changes: 1 addition & 1 deletion test/run/test_experiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ def test_from_title_nonexistent(temp_dir):
mock_get_latest_dir.return_value = nonexistent_path

# The assertion should fail because the directory doesn't exist
with pytest.raises(AssertionError):
with pytest.raises(AssertionError, match=f"Experiment {title} not found"):
Experiment.from_title(title)


Expand Down