Dev deep copy#1626
Conversation
|
@msupernaw can you rebase this PR to main please, there are conflicts with src/rcpp_parameter.cpp and inst/include/interface/rcpp/rcpp_objects/rcpp_interface_base.hpp |
@kellijohnson-NOAA you're fast, lol! will do! |
|
@copilot rebase to main |
Rebased to |
|
Copilot stinks at rebasing and did not do what it said. You will have to do it manually 😉 |
@kellijohnson-NOAA I thought i'd give it a try! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1626 +/- ##
==========================================
+ Coverage 84.88% 84.96% +0.08%
==========================================
Files 105 105
Lines 9473 9491 +18
Branches 536 535 -1
==========================================
+ Hits 8041 8064 +23
+ Misses 1395 1390 -5
Partials 37 37 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
add paths, concurrency, and not run on draft PRs and change to running some things only on main rather than on main and PRs Close #1595
17fda54 to
ab9e39e
Compare
eb122ca to
fd8901b
Compare
What is the feature?
How have you implemented the solution?
Does the PR impact any other area of the project, maybe another repo?
Instructions for code reviewer
👋Hello reviewer👋, thank you for taking the time to review this PR!
nit:(for nitpicking) as the comment type. For example,nit:I prefer using adata.frame()instead of amatrixbecause ...This PR is now ready to be merged.Checklist