R & C++ documentation helper function#1563
Conversation
🎨 Chore: code formatting workflowOur automated workflows cannot run on forks because of permission issues, and thus, we ask that you run the following code locally and push any changes that are created to your feature branch. You will only be reminded of this once per PR. Thank you! Format C++ code
Format R code
styler::style_pkg() # Style R code
roxygen2::roxygenise() # Update documentation
styler::style_pkg() # Style R code again
roxygen2::roxygenise() # Update documentation again
usethis::use_tidy_description() # Style DESCRIPTION filePush changes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1563 +/- ##
==========================================
- Coverage 87.24% 84.46% -2.78%
==========================================
Files 99 70 -29
Lines 9002 7656 -1346
Branches 521 0 -521
==========================================
- Hits 7854 6467 -1387
- Misses 1110 1189 +79
+ Partials 38 0 -38 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5c88e4f to
048d6a8
Compare
|
@e-perl-NOAA I started looking at this PR by installing this version of FIMS and running one example help call and got even though I am positive that I have an internet connection. |
|
@kellijohnson-NOAA did you replace line 29 with `doxygen_base_url <- "https://e-perl-noaa.github.io/FIMS/doxygen/" to run it? Also, it should tell you about the other words that have that in them for you to search in case the first thing it pulls up is not what you want. Also, is R/Rcpp_exports.R generated automatically somewhere, or is it generated manually? |
|
@kellijohnson-NOAA |
|
I made some headway automating the Rcpp_exports.R file using `generate_doxygen_stubs()`where the function is used with roxygen via changing Rcpp_exports.R to be Then, when you run man\fims_cpp.Rdand So, it is not as great as @e-perl-NOAA's internal viewing of the doxygen but I think that it is an improvement on not editing R/Rcpp_exports.R by hand. Where should we go from here? Is the use of ?ReaLVector going to a list of links good enough or do we want to keep |

What is the feature?
?meanorhelp(mean)for the roxygen and doxygen documentation as discussed in the FIMS RE implementation meeting.How have you implemented the solution?
FIMS.tagwith all the function namesfims_help()has an input query of a function and looks through the roxygen and doxygen documentation and pulls up the html file in the Rstudio/positron viewer or in a separate web browser.NOTE: I had to develop this in my fork because I needed to change main, and actually get the pkgdown action to work so that
FIMS.tagactually rendered. Thus, to test this and see how it works, you need to change the following in thefims_help()function:to
and
fims_help()should work.Given that I just needed to get one small thing off my 🍽️ and just went for it 🚀 (sorry @nathanvaughan-NOAA 🤠), and because of that I'm sure there will be lots of comments, suggestions, etc. before it can get merged in.
Instructions for code reviewer
👋Hello reviewer👋, thank you for taking the time to review this PR!
nit:(for nitpicking) as the comment type. For example,nit:I prefer using adata.frame()instead of amatrixbecause ...This PR is now ready to be merged.Checklist