Fix display of SecurityAlgorithm by splitting Display and FromStr macros#657
Draft
tertsdiepraam wants to merge 14 commits into
Draft
Fix display of SecurityAlgorithm by splitting Display and FromStr macros#657tertsdiepraam wants to merge 14 commits into
SecurityAlgorithm by splitting Display and FromStr macros#657tertsdiepraam wants to merge 14 commits into
Conversation
tertsdiepraam
changed the title
SecurityAlgorith by splitting Display and FromStr macrosSecurityAlgorithm by splitting Display and FromStr macros
| ); | ||
|
|
||
| // We want SecurityAlgorithm to parse from a mnemonic from compatibility with | ||
| // some zonefiles, but always print as a number. |
Member
There was a problem hiding this comment.
Can you elaborate? Which zone files. I don't see a problem with mnemonics in user input such as config files. But I don't we should parse that in zone files.
Member
There was a problem hiding this comment.
I didn't realize this. I think the goal of the original PR is completely broken and this should be reverted as quickly as possible.
Contributor
Author
|
Discussed with @withjannisNLnetLabs. He's gonna fix up the docs and set up some tests for this. |
withjannisNLnetLabs
marked this pull request as draft
May 15, 2026 21:57
withjannisNLnetLabs
force-pushed
the
split-macros
branch
from
May 18, 2026 20:01
b916bb1 to
0e85013
Compare
This PR fixes loading of zones that contain a SecurityAlgorithm given as a mnemonic rather than a number as mandated by RFC 4034.
withjannisNLnetLabs
removed their request for review
May 28, 2026 11:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.