Fix zenodraft#443
Conversation
Was already removed from CITATION.cff earlier, we forgot it here.
✅ Deploy Preview for nlesc-guide-testing ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Triggered PDF action: https://github.com/NLeSC/guide/actions/runs/15853408727 |
|
That worked, but there's still an issue: the version now gets autogenerated to be "v1". Maybe this is only a sandbox issue, because we should generate a proper tag when doing a release. However, I'm not completely sure, we should check (added todo to top post). Also, some mysterious entity also again tagged the latest commit in this branch. In this case, the tag is just a shorthand of the commit hash: |
It's superceded by CITATION.cff.
|
Triggered again, now without .zenodo.json: https://github.com/NLeSC/guide/actions/runs/15853945322 |
|
Oops, I forgot to remove the metadata specification from the workflow. Again! https://github.com/NLeSC/guide/actions/runs/15854009546 |
|
Ok, changed a bit too much in one go and of course it fails on that: I fixed the deposition ID, hoping that that would make zenodraft update the existing record: https://sandbox.zenodo.org/records/277498 However, it fails... with a bizarre error, because it seems to be using the wrong URL? It adds one to the ID... |
|
Seems to be a Zenodraft issue, so I reported it there: zenodraft/action#30 For now, we can work around it by simply subtracting 1 from our intended IDs 😄 |
When zenodraft/action#30 is fixed, we can increase the concept IDs again by +1.
for more information, see https://pre-commit.ci
|
Hm, it ran without errors on GH Actions, but the result on Zenodo was a bit weird. Redoing it with verbose logging activated now... https://github.com/NLeSC/guide/actions/runs/15870872596 |
|
Digging through the zenodraft source, it seems like you need a .zenodo.json file after all. At least, there seems to be no CFF support in zenodraft itself. This is why it's not adding any metadata anymore now. |
|
Again with a fix (actually saving the json file...)... https://github.com/NLeSC/guide/actions/runs/15871998697 |
|
The cffconvert action is picky, should work now... https://github.com/NLeSC/guide/actions/runs/15872132299 |
|
Grasping at straws, I put the +1 back in the ID... https://github.com/NLeSC/guide/actions/runs/15872239267 |
|
Trying with a -1 again, but now the concept ID - 1: https://github.com/NLeSC/guide/actions/runs/15881558006 |
|
Ok, I did some debugging with and hacking of Zenodraft to print the extra error information that is sent along with a response 400 (basically what I suggested here zenodraft/zenodraft#92)... and figured out that at least one issue is that there is an existing draft version deposition that may be blocking new version additions! |
This reverts commit ed09aca.
|
|
Hurray, it works! New version drafted! The only thing I still have to manually change is the version, which I assume did not get filled out because I ran the workflow manually. We'll have to see whether it does work when we release in the normal way. |
|
Just as a try-out, I modified the zenodraft action to also produce output and then generate a nice job summary with a link people should follow to actually publish. Triggered... https://github.com/NLeSC/guide/actions/runs/16569483262 |
|
Eh, that run didn't work for mysterious reasons (there was a draft deposition in the Sandbox already, maybe that was clogging up the pipes?), trying again after removing the existing draft... https://github.com/NLeSC/guide/actions/runs/16569578803 |
|
Another mysterious failure. Maybe the wait time was too short between deleting the draft and creating a new one? Also, I "fixed" the entries in the Sandbox by giving them actual versions, because there were two v2's, which I imagine might confuse the system. Maybe I need to create a new deposition altogether... But let's try one more time with this one: https://github.com/NLeSC/guide/actions/runs/16569708398 |
|
Nope, still same error, something with version already existing, weird. Let's try with a new concept_id: https://github.com/NLeSC/guide/actions/runs/16570062845 |
|
Of course that doesn't work either, that concept doesn't exist and this workflow tries to make a new version of an existing concept. Reverted. Let's just publish whatever comes out of the broken workflow and see if that helps for subsequent versions, because there's definitely something screwed up in the order of the two "v2's" that are in the sandbox now. |
This has the built/minified/something version of the version_id output as well.
|
And, of course, weirdly, the workflow runs fine now... No more existing record stuff. Weird. Still, there is no version_id output! Or am I just referencing it wrong? Ah, no I think I should have also "compiled" the zenodraft action code before use, did that, switched to the "production" version... Running... https://github.com/NLeSC/guide/actions/runs/16570636932 |
|
Bam, that works!
Nice clickable link 🙂 And the clickable link is, indeed, clickable and correct! Will have to wait for zenodraft/action#31 before we can use this though, don't want to depend on my crappy version. |
|
Against my own standards, I'd like to merge now without doing a rebase to clean up the history. Ideally, I'd also have liked to reuse the pdf.yml file so that all git history is preserved in one file, instead of now having the additional upload-pdf.yml file with its own history (although most of it is copy-pasted from pdf.yml), but this would require too much rebasing on old stuff, so let's just keep this all as is. |
The upload-pdf.yml workflow was actually copy-pasted initially from the pdf.yml one, so they share history. So long and thanks for all the fish!







Changes in this PR
Following up on #427, trying to fix the zenodraft upload process with some (potential) tweaks and try-outs: