docs(olids): add Compass Equivalent column to schema docs#92
Open
EddieDavison92 wants to merge 2 commits into
Open
docs(olids): add Compass Equivalent column to schema docs#92EddieDavison92 wants to merge 2 commits into
EddieDavison92 wants to merge 2 commits into
Conversation
Restores the Compass mappings from the archived Synapse schema dictionary, matched to the renamed dbt/Snowflake columns. Pads four ragged table rows so the new column aligns.
Corrects values carried over from the archived dictionary that do not exist in the Compass schema: result units columns are result_value_units (not a concept id), supplier codings are non_core_concept_id (not raw_concept_id), and Compass has no age_at_event_baby/neonate, birth date part, clinical_status or referral specialty columns. Fixes organization spelling for two encounter columns.
Collaborator
Author
|
Heads up: after raising this I cross-checked every mapping against the actual Compass source schema and pushed a correction commit - the archived dictionary itself had a few values that don't exist in Compass (details in the description). All remaining mappings now validate against real Compass columns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Compass Equivalent column to each table in
OLIDS/Documentation/Schema/*.md(22 files), restoring the mappings that were present in the archived Synapse schema dictionary but omitted from the new dbt schema docs in #89.How
Synapse-Platform-Archive/OLIDS-schema-dictionary.md, matched by column name per table. Compass itself has not changed, so rows carry the new OLIDS column name with the old Compass value.SUBTYPE<-SUB_TYPE,RECORDED_DATE<-DATE_RECORDED,USUAL_GP_PRACTITIONER_IN_ROLE_ID<-CARE_MANAGER_PRACTITIONER_IN_ROLE_ID, plus two archive typos).SOURCE_EXTRACTION_DATE,LDS_TRANSFORM_DATETIME,SLOT_ID, etc.) show--, following the archive convention.result_value_units(not a concept id), supplier codings arenon_core_concept_id(notraw_concept_id),organisation/organizationspelling on two encounter columns, and Compass has noage_at_event_baby/age_at_event_neonate, birth date part,clinical_statusor referral specialty columns (now--).APPOINTMENT_PRACTITIONER.APPOINTMENT_IDhad an evident copy-paste value in the archive and is--.Notes
Four table rows in Patient_Address.md and Patient_Contact.md had fewer cells than their headers; they are padded so the new column aligns (also fixes four pre-existing MD056 lint errors). No other pre-existing content is modified, and markdownlint reports no new issues.