Use teams by entry lookup for better performance

api/src/main/java/com/velocitypowered/api/scoreboard/ProxyScoreboard.java

@@ -127,6 +127,17 @@ default ProxyObjective createObjective(@NonNull String name, @NonNull Consumer<P
     @NotNull
     Collection<ProxyTeam> getTeams();
 
+    /**
+     * Returns team which the given entry is a member of. If the entry is
+     * not a member of any team, returns {@code null}.
+     *
+     * @param   entry
+     *          Entry to check for team membership
+     * @return  Team which the entry is a member of, or {@code null} if the entry is not a member of any team
+     */
+    @Nullable
+    ProxyTeam getTeamByEntry(@NonNull String entry);
+
     /**
      * Creates a new team builder.
      *

api/src/main/java/com/velocitypowered/api/scoreboard/Scoreboard.java

@@ -75,4 +75,15 @@ public interface Scoreboard {
      */
     @NotNull
     Collection<? extends Team> getTeams();
+
+    /**
+     * Returns team which the given entry is a member of. If the entry is
+     * not a member of any team, returns {@code null}.
+     *
+     * @param   entry
+     *          Entry to check for team membership
+     * @return  Team which the entry is a member of, or {@code null} if the entry is not a member of any team
+     */
+    @Nullable
+    Team getTeamByEntry(@NonNull String entry);
 }

proxy/src/main/java/com/velocitypowered/proxy/data/PacketHandler.java

@@ -226,8 +226,19 @@ public static boolean handle(@NonNull MinecraftSessionHandler handler, @NonNull
         } else {
             // Remove all entries occupied by a proxy team
             if (packet.getEntries() != null) { // Any player action
-                for (VelocityTeam proxyTeam : getProxy(handler).getTeamsRaw()) {
-                    packet.getEntries().removeAll(proxyTeam.getEntryCollection());
+                VelocityScoreboard scoreboard = getProxy(handler);
+                if (packet.getEntries().getEntry() != null) {
+                    VelocityTeam teamByEntry = scoreboard.getTeamByEntry(packet.getEntries().getEntry());
+                    if (teamByEntry != null) {
+                        packet.getEntries().remove(packet.getEntries().getEntry());
+                    }
+                } else {
+                    for (String entry : packet.getEntries().getEntries()) {
+                        VelocityTeam teamByEntry = scoreboard.getTeamByEntry(entry);
+                        if (teamByEntry != null) {
+                            packet.getEntries().remove(entry);
+                        }
+                    }
                 }
             }
         }

proxy/src/main/java/com/velocitypowered/proxy/scoreboard/VelocityScoreboard.java

@@ -152,9 +152,10 @@ public Collection<ProxyTeam> getTeams() {
         return Collections.unmodifiableCollection(teams.values());
     }
 
-    @NotNull
-    public Collection<VelocityTeam> getTeamsRaw() {
-        return teams.values();
+    @Override
+    @Nullable
+    public VelocityTeam getTeamByEntry(@NonNull String entry) {
+        return teamEntries.get(entry);
     }
 
     @ApiStatus.Internal

proxy/src/main/java/com/velocitypowered/proxy/scoreboard/downstream/DownstreamScoreboard.java

@@ -314,17 +314,24 @@ public boolean handle(@NonNull TeamPacket packet) {
                         packet.getName(),
                         Collections.unmodifiableCollection(packet.getEntries().getEntries())
                 ));
-                for (DownstreamTeam allTeams : teams.values()) {
-                    allTeams.getEntryCollection().removeAll(entries);
-                }
-                team.addEntries(entries);
+
                 if (entries.getEntry() != null) {
-                    teamEntries.put(entries.getEntry(), team);
+                    String entry = entries.getEntry();
+                    DownstreamTeam previous = getTeamByEntry(entry);
+                    if (previous != null) {
+                        previous.getEntryCollection().remove(entry);
+                    }
+                    teamEntries.put(entry, team);
                 } else {
                     for (String entry : entries.getEntries()) {
+                        DownstreamTeam previous = getTeamByEntry(entry);
+                        if (previous != null) {
+                            previous.getEntryCollection().remove(entry);
+                        }
                         teamEntries.put(entry, team);
                     }
                 }
+                team.addEntries(entries);
             }
             case REMOVE_PLAYER -> {
                 eventSource.fireEvent(new TeamEvent.RemovePlayers(
@@ -376,14 +383,7 @@ public Collection<? extends Team> getTeams() {
         return Collections.unmodifiableCollection(teams.values());
     }
 
-    /**
-     * Returns team the specified entry belongs to. If it does not belong to any,
-     * {@code null} is returned.
-     *
-     * @param   entry
-     *          Entry to get team of
-     * @return  Team where this entry belongs or {@code null} if none
-     */
+    @Override
     @Nullable
     public DownstreamTeam getTeamByEntry(@NonNull String entry) {
         return teamEntries.get(entry);