Include history stream in climo file names (#410)#459
Merged
Conversation
Climo files are now named {case}_{hist_str}_{var}_climo.nc and are produced
per configured history stream, so a variable present in more than one stream
(e.g. h0 and h1) no longer collides. Climo/timeseries lookups resolve the
stream-aware name in the case's hist_str priority order, then fall back to the
older {case}_{var}_climo.nc convention so pre-existing climo files still work.
- create_climo_files.py: loop over the case's streams; stream-agnostic fallback
when the stream is unknown (e.g. baseline run on pre-made time series).
- adf_dataset.py: optional hist_str filter on the timeseries getters; priority +
old-convention fallback in get_climo_file/get_reference_climo_file.
Also includes a pylint cleanup of both touched files (whitespace, line length,
import order, raise-from, redundant worker imports).
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Co-authored-by: Jesse Nusbaumer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Climo files are now named {case}{hist_str}{var}climo.nc and are produced per configured history stream, so a variable present in more than one stream (e.g. h0 and h1) no longer collides. Climo/timeseries lookups resolve the stream-aware name in the case's hist_str priority order, then fall back to the older {case}{var}_climo.nc convention so pre-existing climo files still work.
Also includes a pylint cleanup of both touched files (whitespace, line length, import order, raise-from, redundant worker imports).