feat(write-stream): WALM-116 relayer write-stream redesign#283
Open
DalenMax wants to merge 29 commits into
Open
feat(write-stream): WALM-116 relayer write-stream redesign#283DalenMax wants to merge 29 commits into
DalenMax wants to merge 29 commits into
Conversation
…uireError variants
…ce new clippy lint
Contributor
Style Guide AuditAudited 4 file(s) against the Sui Documentation Style Guide. 1 violation(s) found. All must be fixed before merge.
|
Collaborator
Author
End-to-end verification updateI re-ran the live Walrus/Sui end-to-end tests that were deferred in the PR description. Both blockers from the earlier session are now resolved. What changed to enable testing
Railway dev results (
|
| Check | Result |
|---|---|
GET /health |
✅ |
GET /version |
✅ |
| Unsigned / wrong-key / expired auth → 401 | ✅ |
POST /api/remember → poll → done |
✅ blob_id=CEdARlLJqVrqxUxA58IaY5om0fF60i5J_CH1fWv17DA |
POST /api/recall |
✅ 1 hit returned |
| 64 KiB remember | ✅ server completed with blob_id; test script expects wrong field name (id vs job_id) |
| 512 KiB remember | ✅ server completed with blob_id; same test-script field issue |
| 1 MiB + 1 remember | ✅ 400 handler-level reject |
Write-stream limiter verification
- Rate limiter returns HTTP 429 after the delegate-key budget is exhausted.
- Prometheus metrics are emitted:
memwal_write_stream_permits_available,memwal_write_stream_waiters_total,memwal_write_stream_acquired_total,memwal_rate_limit_denials_total.
Minor follow-ups (not WALM-116 blockers)
services/server/tests/e2e_test.pychecks for"id"in the remember response, but the API returns"job_id". The size tests fail in the script even though the server jobs succeed.- Henry's Linear comment about combining
/api/analyzefacts into "1 quilt" is a separate storage-layout feature request and should not block this PR.
I believe WALM-116 is ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WriteStreamLimiter./api/remember,/api/remember/bulk,/api/remember/manual,/api/analyze, the wallet-worker upload path, and the legacyexecute_rememberupload path.split_onebatch permits, andWouldExceedCapacityfast-fail mapped to HTTP 429.WALRUS_UPLOAD_MAX_CONCURRENCYsafety-net floor to 12.WRITE_STREAM_MAX_CONCURRENCY,WRITE_STREAM_ACQUIRE_TIMEOUT_MS) and metrics indocs/relayer/.Test Plan
cargo checkpassescargo fmt --checkpassescargo clippy --all-targetsis clean for changed files (pre-existing unrelated lints allowed)cargo test --bin memwal-server→ 313 passed (with local Postgres + Redis viadocker-compose.yml)npm testinservices/server/scripts→ 78 passedTEST_DELEGATE_KEY, on-chain account, and funded server wallets.