Skip to content

Added Calo crystal sim conditions#1851

Open
bechenard wants to merge 1 commit into
Mu2e:mainfrom
bechenard:CaloDBMC
Open

Added Calo crystal sim conditions#1851
bechenard wants to merge 1 commit into
Mu2e:mainfrom
bechenard:CaloDBMC

Conversation

@bechenard

Copy link
Copy Markdown
Contributor

Implementation of conditions for calo simulation parameters (Ray should review). ALso renamed conditions for CaloDAQMap into CalDAQMap to have consistent names. Let pePerMev at 30, will move to 20 when we include the energy calibration. The fcl entry for pePerMev is not yet removed - will do when I revamp the noise, but I need to add support for the disk/crystal position conditions in priority.

@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @bechenard,
You have proposed changes to files in these packages:

  • ProditionsService
  • CaloConfig
  • DbTables
  • CaloReco
  • CaloMC
  • CaloConditions
  • DAQ

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for ddec69e: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at ddec69e.

Test Result Details
test with Command did not list any other PRs to include
merge Merged ddec69e at 83b5e2f
build (prof) Log file. Build time: 04 min 16 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file.
FIXME, TODO ➡️ TODO (6) FIXME (3) in 23 files
clang-tidy ➡️ 30 errors 447 warnings
whitespace check ➡️ found whitespace errors

N.B. These results were obtained from a build of this Pull Request at ddec69e after being merged into the base branch at 83b5e2f.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@rlcee rlcee self-requested a review June 5, 2026 16:22

@rlcee rlcee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked this over carefully, and very nice, you've followed all the db recommendations. One request - you will need an entry in DbTables/inc/DbTableFactory.hh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants