Added Calo crystal sim conditions#1851
Conversation
|
Hi @bechenard,
which require these tests: build. @Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main. ⌛ The following tests have been triggered for ddec69e: build (Build queue - API unavailable) |
|
☀️ The build tests passed at ddec69e.
N.B. These results were obtained from a build of this Pull Request at ddec69e after being merged into the base branch at 83b5e2f. For more information, please check the job page here. |
rlcee
left a comment
There was a problem hiding this comment.
I've looked this over carefully, and very nice, you've followed all the db recommendations. One request - you will need an entry in DbTables/inc/DbTableFactory.hh
Implementation of conditions for calo simulation parameters (Ray should review). ALso renamed conditions for CaloDAQMap into CalDAQMap to have consistent names. Let pePerMev at 30, will move to 20 when we include the energy calibration. The fcl entry for pePerMev is not yet removed - will do when I revamp the noise, but I need to add support for the disk/crystal position conditions in priority.