docs(fdroid): sync recipe prebuild with the verified fdroiddata version - #535
Merged
Conversation
The staged recipe's prebuild had the first-draft path (rm -f gradle/...) which is wrong: prebuild runs in the app/ subdir, so it needs ../gradle/..., and it must also strip the two apply-false Google/Firebase plugin declarations from the root build.gradle.kts (the scanner flags them otherwise). This matches the fdroiddata MR !42096 recipe, which was verified with a full fdroid build (scanner clean + reproduces the published FOSS asset). Co-Authored-By: Claude Opus 4.8 <[email protected]>
monkopedia-reviewer
approved these changes
Jul 4, 2026
monkopedia-reviewer
left a comment
monkopedia-reviewer
left a comment
Collaborator
There was a problem hiding this comment.
Docs-only sync of the staged recipe's prebuild to the verified fdroiddata version: ../gradle/ path (prebuild runs in the app subdir) + sed strips the root apply-false Google/Firebase plugin declarations. Matches MR !42096, verified with a full fdroid build (scanner clean + reproduces). No build/behavior impact. Part of #465. Approving; merge on green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our staged
fdroid/com.rousecontext.ymlhad the first-draftprebuild(rm -f gradle/google-services.gradle.kts), which is wrong on two counts:prebuildruns in theapp/subdir (so it needs../gradle/...), and it must also strip the twoapply falseGoogle/Firebase plugin declarations from the rootbuild.gradle.kts(the scanner flags them). This syncs it to the recipe in fdroiddata MR !42096, verified with a full localfdroid build(scanner clean + reproduces the published FOSS asset). Docs-only; no build/behavior impact. Part of #465.