Move identical iosMain/macosMain TermiosUtil actual into shared appleMain - #239
Merged
Conversation
…Main The termios.setICanon() actual was declared byte-identically in both iosMain and macosMain. Consolidate into a single actual under appleMain (the shared parent that applyDefaultHierarchyTemplate() already gives iosMain and macosMain), and drop the misleading .macosX64 filename suffix since the file covers all apple targets. The nativeMain expect and linuxMain actual are unchanged. Fixes #234 Co-Authored-By: Claude Opus 4.8 <[email protected]>
monkopedia-coder
added
the
ci-apple
monkopedia-reviewer
approved these changes
Jul 10, 2026
monkopedia-reviewer
left a comment
monkopedia-reviewer
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed to merge standard: byte-identical move of the termios.setICanon() actual from iosMain+macosMain into their shared appleMain hierarchy parent; nativeMain expect and linuxMain actual untouched; no other apple actual remains; filename suffix dropped. The one residual concern — apple targets aren't built by the ubuntu-only CI — is now resolved: the new label-triggered apple job (#241) compiled all five iOS/macOS targets on macOS and passed on this PR's actual diff. All 6 checks green. Owner approved conditioned on apple verification, which passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
termios.setICanon()actual was declared byte-for-byte identically in bothiosMainandmacosMain. This consolidates the two copies into a single actualunder
appleMain— the shared hierarchy parent thatapplyDefaultHierarchyTemplate()already givesiosMainandmacosMain— anddrops the misleading
.macosX64filename suffix, since the file applies to allapple targets. The
nativeMainexpectand thelinuxMainactual areuntouched, and no other apple actual for
setICanonremains.Fixes #234
Apple targets are not compiled in CI (ubuntu-only) or locally (cross-compile
disabled); this is a byte-identical move of the existing actual to the
appleMainhierarchy parent that iosMain+macosMain already share, verifiedstructurally — full apple compile occurs at the next publish (macOS).
Verification (
JAVA_HOME=java-21-openjdk):./gradlew :ksrpc-sockets:compileKotlinLinuxX64 :ksrpc-sockets:ktlintCheck—passed, confirming the linux actual and the shared expect still resolve.