Use Protocol buffers for Apache Arrow Flight testers - #50
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Apache Arrow Flight testers to use Protocol Buffers for configuration management and node registration, aligning with the changes in the upstream PR.
- Refactors server and manager clients to serialize and parse protobuf messages instead of plain-encoded strings.
- Removes legacy helper functions (e.g., encode_argument) and related pandas-dependent metrics collection.
- Introduces complete protobuf definitions and compiled files to support the new API.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Apache-Arrow-Flight-Tester/server.py | Updated configuration and update methods to use Protocol Buffers instead of raw encoding. |
| Apache-Arrow-Flight-Tester/protobuf/protocol_pb2.pyi | Added/updated type stubs for the protobuf messages. |
| Apache-Arrow-Flight-Tester/protobuf/protocol_pb2.py | Included the generated protobuf Python module from protocol.proto. |
| Apache-Arrow-Flight-Tester/protobuf/protocol.proto | Added the protobuf definition for ModelarDB Flight protocol. |
| Apache-Arrow-Flight-Tester/manager.py | Modified node registration and database initialization to use protobuf messages. |
| Apache-Arrow-Flight-Tester/common.py | Removed the now-obsolete encode_argument function. |
Comments suppressed due to low confidence (1)
Apache-Arrow-Flight-Tester/server.py:35
- [nitpick] Consider renaming the local variable to avoid shadowing the method name; for example, use 'config_update' instead.
update_configuration = protocol_pb2.UpdateConfiguration()
skejserjensen
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Apache Arrow Flight testers to match the changes made in ModelarData/ModelarDB-RS#335. Note that the protobuf definition file has been copied over and the compiled Python Protocol Buffer definition has been included in git for simplicity.
This PR should not be merged before ModelarData/ModelarDB-RS#335 has been merged.