Fix bug causing in-memory data folder to fail - #340
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where in-memory Delta Lake data folders were failing due to an incorrect path format. The fix addresses issue #339 by adding a leading slash to the memory location path, aligning with the expected format required by recent changes in the object_store crate.
- Updated the memory location path format from
"memory://modelardb"to"memory:///modelardb"
skejserjensen
approved these changes
Aug 1, 2025
chrthomsen
approved these changes
Aug 4, 2025
aabduvakhobov
pushed a commit
to aabduvakhobov/ModelarDB-RS
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #339 by changing the location used for an in-memory
DeltaLake. It is not clear what caused the issue, but it seems that a change to theobject_storecrate made it so a leading/is necessary when specifying the path. The same pattern is consistently used both in tests for theobject_storecrate and for thedelta_lakecrate.