Skip to content

Create a new modelardb_test crate for test functionality #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CGodiksen merged 13 commits into from
Jul 9, 2025
Merged

Create a new modelardb_test crate for test functionality #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e05a375
Add modelardb_test crate
CGodiksen Jul 6, 2025
8c622b1
Move modelardb_common test constants to modelardb_test
CGodiksen Jul 6, 2025
15edd9c
Move data generation test util to modelardb_test crate
CGodiksen Jul 6, 2025
8fd5c87
Move modelardb_storage test util to modelardb_test
CGodiksen Jul 6, 2025
f8cd504
Move argument util functions to manager and server
CGodiksen Jul 6, 2025
6944caf
Move remote util functions to manager and server
CGodiksen Jul 6, 2025
62d8123
Remove modelardb_common crate
CGodiksen Jul 6, 2025
a685c15
Fix Clippy issues
CGodiksen Jul 6, 2025
5ce3fcc
Update import and return type in moved functions
CGodiksen Jul 6, 2025
fa8319b
Fix broken link in dev docs
CGodiksen Jul 7, 2025
a1b53c6
Add text about imports to dev docs
CGodiksen Jul 7, 2025
1ab51e0
Update imports according to new style guide
CGodiksen Jul 7, 2025
c7fe4f5
Update copyright year for files that were moved
CGodiksen Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 13 additions & 18 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

43 changes: 0 additions & 43 deletions crates/modelardb_common/src/arguments.rs
View file
Open in desktop

This file was deleted.

69 changes: 0 additions & 69 deletions crates/modelardb_common/src/error.rs
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions crates/modelardb_common/src/lib.rs
View file
Open in desktop

This file was deleted.

62 changes: 0 additions & 62 deletions crates/modelardb_common/src/remote.rs
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion crates/modelardb_compression/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@ arrow.workspace = true
modelardb_types = { path = "../modelardb_types" }

[dev-dependencies]
modelardb_common = { path = "../modelardb_common" }
modelardb_test = { path = "../modelardb_test" }
proptest.workspace = true
4 changes: 2 additions & 2 deletions crates/modelardb_compression/src/compression.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,8 @@ mod tests {

use arrow::array::{ArrayBuilder, BinaryArray, Float32Array, Int8Array};
use arrow::datatypes::{DataType, Field};
use modelardb_common::test::data_generation::{self, ValuesStructure};
use modelardb_common::test::{ERROR_BOUND_FIVE, ERROR_BOUND_ZERO};
use modelardb_test::data_generation::{self, ValuesStructure};
use modelardb_test::{ERROR_BOUND_FIVE, ERROR_BOUND_ZERO};
use modelardb_types::schemas::COMPRESSED_SCHEMA;
use modelardb_types::types::{TimestampBuilder, ValueBuilder};

Expand Down
2 changes: 1 addition & 1 deletion crates/modelardb_compression/src/models/gorilla.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ pub fn grid(
mod tests {
use super::*;

use modelardb_common::test::{ERROR_BOUND_TEN, ERROR_BOUND_ZERO};
use modelardb_test::{ERROR_BOUND_TEN, ERROR_BOUND_ZERO};
use proptest::num::f32 as ProptestValue;
use proptest::{bool, collection, prop_assert, prop_assert_eq, prop_assume, proptest};

Expand Down
2 changes: 1 addition & 1 deletion crates/modelardb_compression/src/models/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ fn residuals_length(residuals: &[u8]) -> usize {
mod tests {
use super::*;

use modelardb_common::test::{
use modelardb_test::{
ERROR_BOUND_ABSOLUTE_MAX, ERROR_BOUND_ONE, ERROR_BOUND_RELATIVE_MAX, ERROR_BOUND_TEN,
ERROR_BOUND_ZERO,
};
Expand Down
2 changes: 1 addition & 1 deletion crates/modelardb_compression/src/models/pmc_mean.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ pub fn grid(value: Value, timestamps: &[Timestamp], value_builder: &mut ValueBui
mod tests {
use super::*;

use modelardb_common::test::{
use modelardb_test::{
ERROR_BOUND_ABSOLUTE_MAX, ERROR_BOUND_FIVE, ERROR_BOUND_RELATIVE_MAX, ERROR_BOUND_ZERO,
};
use proptest::num::f32 as ProptestValue;
Expand Down
2 changes: 1 addition & 1 deletion crates/modelardb_compression/src/models/swing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ mod tests {

use arrow::array::{BinaryArray, Float32Array, Int8Array};
use arrow::datatypes::{DataType, Field, Schema};
use modelardb_common::test::{
use modelardb_test::{
ERROR_BOUND_ABSOLUTE_MAX, ERROR_BOUND_FIVE, ERROR_BOUND_RELATIVE_MAX, ERROR_BOUND_ZERO,
};
use modelardb_types::schemas::COMPRESSED_SCHEMA;
Expand Down
6 changes: 3 additions & 3 deletions crates/modelardb_compression/src/models/timestamps.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ fn read_decode_and_compute_delta(bits: &mut BitReader, bits_to_read: u8, last_de
mod tests {
use super::*;

use modelardb_common::test::data_generation::generate_timestamps;
use modelardb_test::data_generation;
use proptest::num::i64 as ProptestTimestamp;
use proptest::{collection, proptest};

Expand Down Expand Up @@ -399,13 +399,13 @@ mod tests {

#[test]
fn test_compress_and_decompress_timestamps_for_a_generated_regular_time_series() {
let timestamps = generate_timestamps(1000, false);
let timestamps = data_generation::generate_timestamps(1000, false);
compress_and_decompress_timestamps_for_a_time_series(timestamps.values(), None);
}

#[test]
fn test_compress_and_decompress_timestamps_for_a_generated_irregular_time_series() {
let timestamps = generate_timestamps(1000, true);
let timestamps = data_generation::generate_timestamps(1000, true);
compress_and_decompress_timestamps_for_a_time_series(timestamps.values(), None);
}

Expand Down
4 changes: 2 additions & 2 deletions crates/modelardb_compression/src/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,8 +511,8 @@ mod tests {

use arrow::array::BinaryArray;
use arrow::datatypes::{DataType, Field};
use modelardb_common::test::data_generation::{self, ValuesStructure};
use modelardb_common::test::{ERROR_BOUND_TEN, ERROR_BOUND_ZERO};
use modelardb_test::data_generation::{self, ValuesStructure};
use modelardb_test::{ERROR_BOUND_TEN, ERROR_BOUND_ZERO};
use modelardb_types::schemas::COMPRESSED_SCHEMA;
use modelardb_types::types::{TimestampArray, ValueArray};

Expand Down
1 change: 0 additions & 1 deletion crates/modelardb_embedded/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ async-trait.workspace = true
datafusion.workspace = true
deltalake = { workspace = true, features = ["datafusion", "s3"] }
futures.workspace = true
modelardb_common = { path = "../modelardb_common" }
modelardb_compression = { path = "../modelardb_compression" }
modelardb_storage = { path = "../modelardb_storage" }
modelardb_types = { path = "../modelardb_types" }
Expand Down
Loading