Skip to content

add log for pd nixl#1324

Open
hiworldwzj wants to merge 1 commit into
mainfrom
wzj_pd
Open

add log for pd nixl#1324
hiworldwzj wants to merge 1 commit into
mainfrom
wzj_pd

Conversation

@hiworldwzj
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces GPU timing measurements for memory page copy operations and logs the elapsed time. It also adds latency tracking for adding remote agents in the NIXL KV transporter. The feedback suggests defensively checking that both copy_start_event and copy_end_event are not None before calculating the elapsed time to prevent potential AttributeError exceptions.

Comment on lines +362 to +364
if copy_end_event is not None:
copy_end_event.synchronize()
read_page_gpu_time_ms = copy_start_event.elapsed_time(copy_end_event)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To ensure robust defensive programming, verify that both copy_end_event and copy_start_event are not None before calling elapsed_time to prevent potential AttributeError exceptions.

Suggested change
if copy_end_event is not None:
copy_end_event.synchronize()
read_page_gpu_time_ms = copy_start_event.elapsed_time(copy_end_event)
if copy_end_event is not None and copy_start_event is not None:
copy_end_event.synchronize()
read_page_gpu_time_ms = copy_start_event.elapsed_time(copy_end_event)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant