Handle missing base discount curve and log once#47
Closed
oszette wants to merge 1 commit into
Closed
Conversation
Add robust handling for missing base discount curves during cashflow report generation. Both cashflowutils.cpp and trade.cpp now include the logging header and use a missingBaseDiscountCurveLogged flag to emit a single DLOG entry when the base discount curve cannot be retrieved. Retrievals of the base discount curve are wrapped in try/catch blocks so cashflow processing continues with null discount factors instead of throwing. Also add a pay-date null check before attempting base curve lookup and adjust the baseDiscountCurve type/usage when constructing indexed coupon objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ORE v16 force you to send in a discount curve in base currency to generate flows.csv (in this commit). We could of course also change VL s.t. you always send in a base currency discount curve, but I guess that would need to be a hardcoded list per source per currency, or something.