feat(sdk): add tsd type tests for SDK return types#403
Open
blockchain-maxis wants to merge 2 commits into
Open
feat(sdk): add tsd type tests for SDK return types#403blockchain-maxis wants to merge 2 commits into
blockchain-maxis wants to merge 2 commits into
Conversation
Adds sdk/test-d/index.test-d.ts with 54 assertions covering WalletConfig, WebAuthnSignature, RegisterResult, DeployResult, AddSignerResult, RotateSignerResult, SignerInfo, InitiateRecoveryResult, StorageAdapter, InvisibleWallet, OutboxStatus/Entry, Sep7PayRequest, Sep7MemoType, SignedMessage, and all three error classes. Adds tsd devDependency and test-d script (builds then runs tsd). closes Miracle656#260
|
@blockchain-maxis is attempting to deploy a commit to the miracle656's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@blockchain-maxis Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sdk/test-d/index.test-d.tswith 54 type assertions covering the most-used SDK return typestsdas a devDependency tosdk/package.jsontest-dscript (npm run build && tsd) so CI can verify types without a separate build stepType coverage
WalletConfig,StorageAdapterWebAuthnSignature,AuthenticatorAttachmentRegisterResult,DeployResult,AddSignerResult,RotateSignerResultSignerInfo,InitiateRecoveryResultInvisibleWallet(address, flags, register, deploy)OutboxStatus,OutboxEntrySep7MemoType,Sep7PayRequestSignedMessageRecoveryTimelockActive,NoGuardianSet,RecoveryNotPendingBoth positive (
expectAssignable) and negative (expectNotAssignable) assertions are included for all union types.Verification
closes #260