feat: implement stablecoin peg deviation benchmark route#107
feat: implement stablecoin peg deviation benchmark route#107barnabasolutayo-lgtm wants to merge 2 commits into
Conversation
|
@barnabasolutayo-lgtm Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Miracle656
left a comment
There was a problem hiding this comment.
Verified: registerBenchmarkRoutes(app) wired in index.ts; /benchmark/:asset queries price_points with valid pair_key/timestamp columns, parameterized, 404 on unwatched pair; includes a test. Clean merge with main. Closes #98.
Miracle656
left a comment
There was a problem hiding this comment.
The route itself looks good — registerBenchmarkRoutes wired in index.ts, /benchmark/:asset over price_points (valid pair_key/timestamp), 404 on unwatched pair, parameterized, with a test. The only blocker is that it now conflicts with sibling routes that merged since you branched (both touch src/index.ts route registration and src/api/schemas.ts).
A quick rebase resolves it:
git fetch origin
git rebase origin/main
# in src/index.ts keep ALL registerXxxRoutes(app) lines (union), same for schemas.ts
git push --force-with-leaseThen I'll merge. Thanks!
##closes #98