Update Converter.cc for mbs data format#110
Merged
Merged
Conversation
Adjusted the range for the Qint raw histograms for data with the mbs format. First if and else if condition has to be changed
lpgaff
reviewed
Jun 5, 2026
| // Check if we have particles with low gain preamps (heavy ions, Coulex) | ||
| if( ( cal->FebexType(i,j,k) == "Qshort" && cal->FebexGain(i,j,k) > 5 ) | ||
| || ( cal->FebexType(i,j,k) == "Qint" && cal->FebexGain(i,j,k) > 0.0005 ) ) { | ||
| || ( cal->FebexType(i,j,k) == "Qint" && cal->FebexGain(i,j,k) > 0.005 ) ) { |
Contributor
There was a problem hiding this comment.
is this change intended? The usual difference between the Qshort and Qint values is 1e4. Therefore, if you change the condition on the Qint to be 5e-3, then the Qshort condition should be 5e1, which is 50.
If you change one, you must change the other, but maybe this change was not intended?
Adjusted Qshort to match the Qint condition in the first if statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusted the range for the Qint raw histograms for data with the mbs format. This is only important for data with the mbs format (data collected in 2022).