refactor(config): single-purpose composable classes#557
Open
MattSturgeon wants to merge 4 commits into
Open
Conversation
De-couple the raw data (DTO) from domain logic (adapter).
Combine it into ModConfig propper.
Orchestrate & register composable config controllers from ModConfig.setup() Split up knowledge of DTO and domain adapter.
Extract GsonConfigLoader's responsibilities into single-responsibility ConfigLoader and ConfigSerializer implementations, which are composed in `ModConfig.setup()`.
MattSturgeon
force-pushed
the
decouple-config-dto
branch
from
July 26, 2026 07:50
0982aea to
493e732
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #556, this is the general cleanup and refactoring done while working towards splitting off a separate
:configGradle project.Merging this separately reduces per-PR scope, allowing #556 to focus on moving classes to the new
:configproject and introducing tests, while this PR focusses on the system cleanup and refactoring.ModConfigimplementation from the DTO class, moving it to a domain adapterModConfigImpl.SingletonModConfigControllerwith separate DTO controller and domain-adapter controllers, which are composed inModConfig.setup().ConfigControllerRegistry.init()and intoModConfig.setup().GsonConfigLoaderresponsibilities into new single-responsibilityConfigLoaderandConfigSerializerimplementations, which are composed inModConfig.setup().