refactor(config): de-couple from Minecraft & Gson#544
Draft
MattSturgeon wants to merge 6 commits into
Draft
Conversation
MattSturgeon
force-pushed
the
decouple-config
branch
2 times, most recently
from
July 17, 2026 13:40
987e3b6 to
4b9cb09
Compare
MattSturgeon
force-pushed
the
decouple-config
branch
from
July 24, 2026 22:43
4b9cb09 to
acfc468
Compare
De-couple the raw data (DTO) from domain logic (adapter).
Combine it into ModConfig propper.
MattSturgeon
force-pushed
the
decouple-config
branch
from
July 25, 2026 00:35
acfc468 to
3c6f538
Compare
MattSturgeon
marked this pull request as ready for review
July 25, 2026 00:52
MattSturgeon
marked this pull request as draft
July 25, 2026 05:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Refactor the config system to isolate the core domain logic from Minecraft and its Gson library.
Previously, this tight coupling hindered maintainability and made the data layer difficult to test without initializing game instances.
We can now run fast, isolated unit tests and also avoid the core architecture being locked into specific dependencies.
Overview of Changes
:configsubproject, completely free of Minecraft dependencies.ConfigSerializerandRawConfigNode, removing direct Gson references from the core logic.ModConfigDTO) from the domain adapter (ModConfigImpl).Build/CoreCI job to the matrix, which runs unit tests via:config:check. This job can also run other non-mc project tests in the future, too.:build-logicCI job for now, because that runs with--project-dir. Maybe it'd be worth combining these two jobs together, though?