refactor(config): show a user-facing error screen when missing#380
Merged
MattSturgeon merged 1 commit intoMar 31, 2026
Merged
Conversation
MattSturgeon
force-pushed
the
fallback-gui
branch
from
March 29, 2026 19:51
f70bb9b to
f4cf910
Compare
MattSturgeon
force-pushed
the
stonecutter
branch
from
March 29, 2026 20:09
c913d36 to
9f45c4a
Compare
MattSturgeon
force-pushed
the
fallback-gui
branch
5 times, most recently
from
March 31, 2026 01:27
0ca5cac to
9f67389
Compare
hashalite
approved these changes
Mar 31, 2026
MattSturgeon
force-pushed
the
fallback-gui
branch
from
March 31, 2026 01:42
9f67389 to
db8b40c
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than skipping config screen registration when no provider is available, show a fallback screen with a user-facing error message.
This simplifies code, because we don't need to handle
Optionalpresence.This provides a better user experience, because they see that Freecam can support configs, but currently does not.
We could combine both systems; skip registering config support when no providers are loaded but show a fallback screen when some are loaded but none are "available" (have their dependencies loaded). This is the worst of both worlds in terms of complexity, though.
Feature creep
Moved to #384