ALFMOB-266: Integrate typography tokens (Figma-named provider + full call-site migration) by khoinguyen-mindera · Pull Request #87 · Mindera/Alfie-iOS

khoinguyen-mindera · 2026-06-29T09:02:32Z

ALFMOB-266 — Integrate typography tokens from design token JSON

Ticket: ALFMOB-266 · Epic: ALFMOB-264 · ADR: ALFMOB-293

What & why

Drives the iOS typography system from the generated design tokens (SharedUI/GeneratedTokens/Typography+Generated.swift) instead of hardcoded constants. Per the epic ADR, the public typography surface now uses the Figma token names verbatim — the legacy header/paragraph/small/tiny system is removed. The themed-provider middle layer is kept (DI-injected, mockable); UI code never touches Typography.* directly.

Scope note: this absorbs most of ALFMOB-267 (the full call-site migration) per product direction.

Changes

New token-driven provider — theme.font.display / heading / body / label / link.*, each a ThemedTypographyStyle value type:
- theme.font.heading.large("Title") → styled AttributedString (callAsFunction; underline:/strike: params)
- theme.font.body.medium.uiFont → UIFont for UIKit/.font(Font(…))/.withSize sites
Bridge TypographyStyle.uiFont: "SF Pro" → UIFont.systemFont(ofSize:weight:) (not UIFont(name:)); "Libre Baskerville" → bundled brand face; weight Int → UIFont.Weight (400→.regular, 500→.medium); token line-height + kerning applied via the existing AttributedString.build.
Brand font — bundled Libre Baskerville Regular (SIL OFL 1.1, free for commercial use) in Fonts.xcassets + OFL.txt; registered via the existing AlfieApp FontManager.registerAll() launch hook.
Migrated all ~250 call sites across ~80 files (SharedUI, DebugMenu, feature modules) to the new API.
Removed the legacy Typography{Header,Paragraph,Small,Tiny} protocols/classes; trimmed TypographyProvider; setupAppearance() → heading.small.uiFont.
Tests — new TypographyStyleFontTests + TypographyProviderTokenTests (pointSize/weight/family resolution, system-vs-UIFont(name:), brand registration, provider == token).

Token mapping (legacy → Figma)

header.h1→heading.large (36→32) · h2→heading.medium · h3→heading.small · paragraph.*→body.medium · small.*→body.small (14→12) · tiny.*→body.small. Underline/strike preserved via params; bold/italic distinctions dropped (legacy already rendered as a single Medium face).

⚠️ Expected visual changes (accepted)

Tokens now apply real line-height, kerning and weights, so themed text shifts app-wide: h1 36→32, small 14→12, body weight → regular, small/tiny converge at 12pt, bold emphasis dropped. Snapshot tests are disabled (pre-existing), so these have no automated visual coverage — value-equality unit tests + a manual DebugMenu Typography check only. Visual polish/baseline refresh is deliberately out of scope.

Verification

./Alfie/scripts/verify.sh --skip-integration → ✅ build + unit tests pass (integration skipped — no local BFF). Multi-lens code review (foundation + migration/adversarial): clean.

Notes

No edits to GeneratedTokens/ or project.pbxproj.
Planning artifacts (scope/plan/grill/red-team) under Docs/Plans/ALFMOB-266-integrate-typography-tokens/.

🤖 Generated with Claude Code

…indings

…ping

…clear stale pulled JSON

…rs.xcassets

…token ramps)

…, fix demo dupes, sync plan docs

…onsistent demo Black swatch

…ate-color-tokens

…tegration

… otherwise)

…rate call sites

…rced

…ctly

…ape) + Environment seam

…leCrossedOutShape directly

…rated token)

…System

…ken test

Copilot

Pull request overview

This PR migrates Alfie iOS typography to be driven by generated design tokens, exposing a new Figma-named typography surface via ThemeProvider.shared.font and updating all call sites to use it, while bundling/registering the brand font and adding unit coverage for token-to-font bridging.

Changes:

Introduces token-driven typography API (theme.font.display/heading/body/label/link) backed by ThemedTypographyStyle (callAsFunction + .uiFont).
Removes the legacy header/paragraph/small/tiny typography system and migrates SharedUI, DebugMenu, and feature-module call sites.
Adds Libre Baskerville (license + asset catalog entry) and unit tests validating font resolution and provider/token consistency.

Reviewed changes

Copilot reviewed 107 out of 108 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
Docs/Plans/ALFMOB-266-integrate-typography-tokens/scope.md	Documents token contract + legacy system scope
Docs/Plans/ALFMOB-266-integrate-typography-tokens/red-team.md	Red-team findings and resolutions
Docs/Plans/ALFMOB-266-integrate-typography-tokens/plan.md	Full migration plan and ACs
Docs/Plans/ALFMOB-266-integrate-typography-tokens/phase-5-remove-legacy.md	Legacy removal steps/checklist
Docs/Plans/ALFMOB-266-integrate-typography-tokens/phase-4-migrate-features-tests.md	Feature-module migration steps
Docs/Plans/ALFMOB-266-integrate-typography-tokens/phase-3-migrate-debugmenu.md	DebugMenu migration steps
Docs/Plans/ALFMOB-266-integrate-typography-tokens/phase-2-migrate-sharedui.md	SharedUI migration steps
Docs/Plans/ALFMOB-266-integrate-typography-tokens/phase-1-foundation.md	Foundation bridge/provider plan
Docs/Plans/ALFMOB-266-integrate-typography-tokens/grill.md	Decision record for rename-now migration
Docs/Plans/ALFMOB-266-integrate-typography-tokens/dev-foundation.md	Phase-1 implementation summary
Docs/Plans/ALFMOB-266-integrate-typography-tokens/dev-3.md	Feature-module migration summary
Docs/Plans/ALFMOB-266-integrate-typography-tokens/dev-2.md	DebugMenu migration summary
Docs/Plans/ALFMOB-266-integrate-typography-tokens/dev-1.md	SharedUI migration summary
Docs/Plans/ALFMOB-266-integrate-typography-tokens/_status.md	Work status checklist and verification notes
Alfie/AlfieKit/Tests/SharedUITests/Typography/TypographyStyleFontTests.swift	Tests for token→UIFont mapping + invariants
Alfie/AlfieKit/Tests/SharedUITests/Typography/TypographyProviderTokenTests.swift	Tests ensuring provider styles match tokens
Alfie/AlfieKit/Sources/Web/UI/WebView.swift	Migrates error view typography call sites
Alfie/AlfieKit/Sources/SharedUI/Theme/Typography/TypographyProvider.swift	Replaces legacy provider surface with Figma groups
Alfie/AlfieKit/Sources/SharedUI/Theme/Typography/ThemedTypographyStyle.swift	Adds callable style wrapper + `.uiFont`
Alfie/AlfieKit/Sources/SharedUI/Theme/Typography/Specifications/TypographyTinyProtocol.swift	Deletes legacy tiny typography spec
Alfie/AlfieKit/Sources/SharedUI/Theme/Typography/Specifications/TypographySmallProtocol.swift	Deletes legacy small typography spec
Alfie/AlfieKit/Sources/SharedUI/Theme/Typography/Specifications/TypographyParagraphProtocol.swift	Deletes legacy paragraph typography spec
Alfie/AlfieKit/Sources/SharedUI/Theme/Typography/Specifications/TypographyHeaderProtocol.swift	Deletes legacy header typography spec
Alfie/AlfieKit/Sources/SharedUI/Theme/Typography/Specifications/TypographyGroups.swift	Adds Figma group protocols + implementations
Alfie/AlfieKit/Sources/SharedUI/Theme/Typography/Resources/LibreBaskerville-OFL.txt	Adds OFL license text for bundled font
Alfie/AlfieKit/Sources/SharedUI/Theme/Typography/Resources/Fonts.xcassets/LibreBaskerville-Regular.dataset/Contents.json	Adds font asset catalog entry
Alfie/AlfieKit/Sources/SharedUI/Theme/Typography/Helpers/TypographyStyle+Font.swift	Adds typography token bridge + build(style:)
Alfie/AlfieKit/Sources/SharedUI/Theme/Typography/Helpers/FontNames.swift	Adds Libre Baskerville font name + filename mapping
Alfie/AlfieKit/Sources/SharedUI/Theme/ThemeProvider.swift	Updates appearance setup to new typography API
Alfie/AlfieKit/Sources/SharedUI/Theme/Segmented/ThemedSegmentedView.swift	Migrates segmented view typography
Alfie/AlfieKit/Sources/SharedUI/Theme/Modal/ThemedModal.swift	Migrates modal typography
Alfie/AlfieKit/Sources/SharedUI/Theme/Inputs/ThemedInput.swift	Migrates input typography + `.uiFont` usage
Alfie/AlfieKit/Sources/SharedUI/Theme/Components/SizingBanner/SizingSwatchView.swift	Migrates sizing swatch typography
Alfie/AlfieKit/Sources/SharedUI/Theme/Components/SizingBanner/ColorAndSizingSelectorHeaderView.swift	Migrates sizing header typography
Alfie/AlfieKit/Sources/SharedUI/Theme/Components/SearchBar/ThemedSearchBarView.swift	Migrates search bar typography + `.uiFont` usage
Alfie/AlfieKit/Sources/SharedUI/Theme/Components/RadioButton/RadioButton.swift	Migrates radio button typography
Alfie/AlfieKit/Sources/SharedUI/Theme/Components/Loader/ThemedLoaderView.swift	Migrates loader typography
Alfie/AlfieKit/Sources/SharedUI/Theme/Components/Loader/LoaderView.swift	Migrates loader typography
Alfie/AlfieKit/Sources/SharedUI/Theme/Components/Checkbox/Checkbox.swift	Migrates checkbox typography
Alfie/AlfieKit/Sources/SharedUI/Theme/Buttons/ThemedButton.swift	Migrates button typography + underline param
Alfie/AlfieKit/Sources/SharedUI/Theme/Accordion/AccordionView.swift	Migrates accordion typography
Alfie/AlfieKit/Sources/SharedUI/Helpers/Modifiers/Shimmering/MultilineShimmerEffectModifier.swift	Migrates shimmer modifier typography + `.uiFont`
Alfie/AlfieKit/Sources/SharedUI/Components/Toolbar/ThemedToolbarTitle.swift	Migrates toolbar title typography + `.uiFont`
Alfie/AlfieKit/Sources/SharedUI/Components/Toolbar/ThemedToolbarButton.swift	Migrates toolbar button typography + `.uiFont`
Alfie/AlfieKit/Sources/SharedUI/Components/Tags/Tag.swift	Migrates tag typography
Alfie/AlfieKit/Sources/SharedUI/Components/TabControl/TabControl.swift	Migrates tab control typography
Alfie/AlfieKit/Sources/SharedUI/Components/SortBy/SortByView.swift	Migrates sort-by typography + static Font usage
Alfie/AlfieKit/Sources/SharedUI/Components/Snackbar/SnackbarView.swift	Migrates snackbar typography
Alfie/AlfieKit/Sources/SharedUI/Components/ProductCards/VerticalProductCardConfiguration+Extension.swift	Migrates card configuration UIFont access
Alfie/AlfieKit/Sources/SharedUI/Components/ProductCards/HorizontalProductCard.swift	Migrates product card typography
Alfie/AlfieKit/Sources/SharedUI/Components/Price/PriceComponentView.swift	Migrates price typography + `.uiFont` sizing
Alfie/AlfieKit/Sources/SharedUI/Components/Indicators/PaginatedControl.swift	Migrates pagination typography + `.uiFont` usage
Alfie/AlfieKit/Sources/SharedUI/Components/Indicators/BadgeViewModifier.swift	Migrates badge typography
Alfie/AlfieKit/Sources/SharedUI/Components/Indicators/BadgeTabViewModifier.swift	Migrates badge appearance UIFont usage
Alfie/AlfieKit/Sources/SharedUI/Components/ErrorView/ErrorView.swift	Migrates optional mapping to callable style
Alfie/AlfieKit/Sources/SharedUI/Components/Chips/Chip.swift	Migrates chip typography
Alfie/AlfieKit/Sources/SharedUI/Components/Carousel/ProductCarousel/ProductCarouselHeader.swift	Migrates carousel header typography
Alfie/AlfieKit/Sources/SharedUI/Components/AppUpdate/ForceAppUpdateView.swift	Migrates app update typography
Alfie/AlfieKit/Sources/Search/UI/SearchView.swift	Migrates search empty-state typography
Alfie/AlfieKit/Sources/Search/UI/RecentSearchesView.swift	Migrates recent-searches typography + underline param
Alfie/AlfieKit/Sources/ProductListing/UI/ProductListingFilterBar.swift	Migrates PLP filter bar typography
Alfie/AlfieKit/Sources/ProductListing/UI/ProductListingFilter.swift	Migrates static Font constant to `.uiFont`
Alfie/AlfieKit/Sources/ProductDetails/UI/ProductDetailsView.swift	Migrates PDP typography including ErrorView
Alfie/AlfieKit/Sources/ProductDetails/UI/ProductDetailsColorAndSizeSheet.swift	Migrates PDP sheet typography + `.uiFont`
Alfie/AlfieKit/Sources/MyAccount/UI/AccountSectionView.swift	Migrates account section typography
Alfie/AlfieKit/Sources/Home/UI/HomeView.swift	Migrates home title typography
Alfie/AlfieKit/Sources/DebugMenu/UI/FeatureToggle/FeatureToggleView.swift	Migrates feature toggle typography + `.uiFont`
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Typography/TypographyDemoView.swift	Updates demo to new typography groups
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Toolbar/ToolbarDemoView.swift	Migrates toolbar demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Toggle/ToggleDemoView.swift	Migrates toggle demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Tags/TagDemoView.swift	Migrates tag demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/TabControl/TabControlIntrinsicWidthDemoView.swift	Migrates tab control demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/TabControl/TabControlFixedWidthDemoView.swift	Migrates tab control demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/StyleGuideDemoView.swift	Migrates style guide demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Spacing/SpacingDemoView.swift	Migrates spacing demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Snackbars/SnackbarDemoView.swift	Migrates snackbar demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Shimmering/ShimmerDemoView.swift	Migrates shimmer demo typography + `.uiFont`
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Shadow/ShadowDemoView.swift	Migrates shadow demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Segments/SegmentsDemoView.swift	Migrates segments demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/SearchBar/SearchBarDemoView.swift	Migrates search bar demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Pricing/PriceComponentDemoView.swift	Migrates pricing demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/PageControl/PageControlDemoView.swift	Migrates page control demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Motion/MotionDemoView.swift	Migrates motion demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Modal/ModalDemoView.swift	Migrates modal demo typography + `.uiFont`
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Loading/LoadingDemoView.swift	Migrates loading demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Inputs/InputDemoView.swift	Migrates input demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Indicators/BadgeDemoView.swift	Migrates badge demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Iconography/IconographyDemoView.swift	Migrates iconography demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Helper/DemoHelper.swift	Migrates demo helper typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Dividers/DividerDemoView.swift	Migrates divider demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/CornerRadius/CornerRadiusDemoView.swift	Migrates corner radius demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Components/RadioListDemoView.swift	Migrates radio list demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Components/DatePickerDemoView.swift	Migrates date picker demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Components/ChipsDemoView.swift	Migrates chips demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Colors/ColorsDemoView.swift	Migrates colors demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/CarouselDemoView/CarouselDemoView.swift	Migrates carousel demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Buttons/ButtonDemoView.swift	Migrates button demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Accordion/AccordionDemoView.swift	Migrates accordion demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/DeepLinking/DeepLinkDemoView.swift	Migrates deep link demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/DebugMenuView.swift	Migrates debug menu navigation typography
Alfie/AlfieKit/Sources/DebugMenu/UI/Configuration/AppUpdateDemoView.swift	Migrates app update demo typography
Alfie/AlfieKit/Sources/DebugMenu/UI/BrazePush/BrazeDemoView.swift	Migrates braze demo typography
Alfie/AlfieKit/Sources/CategorySelector/UI/CategoriesView.swift	Migrates categories typography
Alfie/AlfieKit/Sources/CategorySelector/UI/BrandsView.swift	Migrates brands typography + `.uiFont` uses
Alfie/AlfieKit/Sources/AppFeature/UI/TabBarItemView.swift	Migrates tab bar item typography
Alfie/AlfieKit/Sources/AppFeature/UI/ForceAppUpdateView.swift	Migrates force update typography
Alfie/AlfieKit/Package.swift	Adds OFL license file as packaged resource

…ng/lineHeight tests; collapse dead switch

…ied/Mesure typos

Copilot

Pull request overview

Copilot reviewed 107 out of 108 changed files in this pull request and generated 2 comments.

Adopt Primitives.Colours.* design tokens; delete legacy Colors.primary/ secondary providers + Colors.xcassets. Conflicts resolved by keeping 266's typography API (font.display/heading/body/label/link) and taking 274's color tokens. No legacy Colors.* or old font API remain.

Adopt Primitives.Spacing.* and Sizing.* tokens; rename provider ThemeProvider -> DesignSystem (font + spacing + shape). Conflicts resolved keeping 266 typography (font.body/heading/display) + color tokens, taking 270 spacing/shape tokens + DesignSystem name. No legacy Colors/Spacing/ CornerRadius or old font API remain.

…r.xcassets ThemedToggleView's ColorToggle now references Primitives.Colours.* (greys -> neutrals, on-state greens -> semanticSuccess) instead of the ToggleColor.xcassets asset catalog, which is removed. No asset-catalog Color("...") refs remain in SharedUI. App-shell AccentColor/LaunchScreenBackground kept (build-setting/ storyboard, outside the token pipeline).

Color.white -> Primitives.Colours.neutrals0 (ColorSwatchView); Color.clear / UIColor.clear -> Primitives.Colours.transparentTransparent(.ui) across app, SharedUI, AppFeature, CategorySelector. Utils leaf module keeps Color.clear (no SharedUI dependency; structural GeometryReader background). Also drop the stale ToggleColor.xcassets resource entry from Package.swift.

…typography-tokens # Conflicts: # Alfie/AlfieKit/Sources/AppFeature/UI/ForceAppUpdateView.swift # Alfie/AlfieKit/Sources/AppFeature/UI/TabBarItemView.swift # Alfie/AlfieKit/Sources/CategorySelector/UI/BrandsView.swift # Alfie/AlfieKit/Sources/DebugMenu/UI/Configuration/AppUpdateDemoView.swift # Alfie/AlfieKit/Sources/DebugMenu/UI/DeepLinking/DeepLinkDemoView.swift # Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Buttons/ButtonDemoView.swift # Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/CarouselDemoView/CarouselDemoView.swift # Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Colors/ColorsDemoView.swift # Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/CornerRadius/CornerRadiusDemoView.swift # Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Dividers/DividerDemoView.swift # Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Helper/DemoHelper.swift # Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Iconography/IconographyDemoView.swift # Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Inputs/InputDemoView.swift # Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Loading/LoadingDemoView.swift # Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Modal/ModalDemoView.swift # Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Motion/MotionDemoView.swift # Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Pricing/PriceComponentDemoView.swift # Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/SearchBar/SearchBarDemoView.swift # Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Shadow/ShadowDemoView.swift # Alfie/AlfieKit/Sources/DebugMenu/UI/Demo/Shimmering/ShimmerDemoView.swift # Alfie/AlfieKit/Sources/ProductDetails/UI/ProductDetailsColorAndSizeSheet.swift # Alfie/AlfieKit/Sources/ProductDetails/UI/ProductDetailsView.swift # Alfie/AlfieKit/Sources/ProductListing/UI/ProductListingFilter.swift # Alfie/AlfieKit/Sources/ProductListing/UI/ProductListingFilterBar.swift # Alfie/AlfieKit/Sources/Search/UI/RecentSearchesView.swift # Alfie/AlfieKit/Sources/Search/UI/SearchView.swift # Alfie/AlfieKit/Sources/SharedUI/Components/AppUpdate/ForceAppUpdateView.swift # Alfie/AlfieKit/Sources/SharedUI/Components/Carousel/ProductCarousel/ProductCarouselHeader.swift # Alfie/AlfieKit/Sources/SharedUI/Components/Chips/Chip.swift # Alfie/AlfieKit/Sources/SharedUI/Components/ErrorView/ErrorView.swift # Alfie/AlfieKit/Sources/SharedUI/Components/Indicators/BadgeViewModifier.swift # Alfie/AlfieKit/Sources/SharedUI/Components/Price/PriceComponentView.swift # Alfie/AlfieKit/Sources/SharedUI/Components/ProductCards/HorizontalProductCard.swift # Alfie/AlfieKit/Sources/SharedUI/Components/ProductCards/VerticalProductCardConfiguration+Extension.swift # Alfie/AlfieKit/Sources/SharedUI/Components/SortBy/SortByView.swift # Alfie/AlfieKit/Sources/SharedUI/Components/Toolbar/ThemedToolbarTitle.swift # Alfie/AlfieKit/Sources/SharedUI/Helpers/Modifiers/Shimmering/MultilineShimmerEffectModifier.swift # Alfie/AlfieKit/Sources/SharedUI/Theme/Components/ColorBanner/ColorSwatchView.swift # Alfie/AlfieKit/Sources/SharedUI/Theme/Components/Loader/LoaderView.swift # Alfie/AlfieKit/Sources/SharedUI/Theme/Components/Loader/ThemedLoaderView.swift # Alfie/AlfieKit/Sources/SharedUI/Theme/Components/SearchBar/ThemedSearchBarView.swift # Alfie/AlfieKit/Sources/SharedUI/Theme/Components/SizingBanner/ColorAndSizingSelectorHeaderView.swift # Alfie/AlfieKit/Sources/SharedUI/Theme/DesignSystem.swift # Alfie/AlfieKit/Sources/SharedUI/Theme/Inputs/ThemedInput.swift # Alfie/AlfieKit/Sources/SharedUI/Theme/Modal/ThemedModal.swift # Alfie/AlfieKit/Sources/SharedUI/Theme/Segmented/ThemedSegmentedView.swift # Alfie/AlfieKit/Sources/Web/UI/WebView.swift

Copilot

Pull request overview

Copilot reviewed 124 out of 125 changed files in this pull request and generated 2 comments.

… assert all token fields

Copilot

Pull request overview

Copilot reviewed 124 out of 125 changed files in this pull request and generated 2 comments.

+    override func setUp() {
+        super.setUp()
+        // Brand (Display) styles resolve via UIFont(name:), so the bundled face must be registered.
+        try? FontManager.registerAll()
+    }


+    override func setUp() {
+        super.setUp()
+        // The brand (Display) face resolves through UIFont(name:), so it must be registered.
+        try? FontManager.registerAll()
+    }


amccall-mindera

Approving ALFMOB-266. Typography is now token-driven end-to-end: the UIFont bridge resolves SF Pro via systemFont and the brand face via UIFont(name:) with a safe size/weight-preserving fallback; AttributedString builders reuse the existing line-height/kerning path; Libre Baskerville is bundled and registered at launch; and the provider→token unit tests compare all token fields (family/weight/size/lineHeight/letterSpacing), not just point size. The ~250-site migration and removal of the legacy Header/Paragraph/Small/Tiny protocols are per the epic ADR (absorbing ALFMOB-267) — worth updating the AC wording to match. App-wide visual shifts are accepted per the PR description. Prior Copilot threads reviewed; the remaining try? FontManager.registerAll() in test setup is a minor test-robustness nit, not blocking.

khoinguyen-mindera added 30 commits June 18, 2026 17:18

ALFMOB-264: Add design system token integration epic plan

08f105f

ALFMOB-272: Add Phase 1 token pipeline red-team, validation & spike f…

187f39e

…indings

ALFMOB-272: Add design token codegen pipeline (DesignTokenGen)

2bb3eb1

ALFMOB-272: Address PR review — color alpha key, strict parsing, esca…

a293245

…ping

ALFMOB-272: Add tests for literal escaping and broken-ref-in-output

d7cfac7

Merge branch 'main' into ALFMOB-272-design-token-codegen

ac77e42

ALFMOB-274: Replace hardcoded color palette with generated design tokens

8b8fc0b

ALFMOB-274: Add color-token integration plan, mapping & decisions

48298bf

ALFMOB-274: Mark plan completed; record deferred follow-ups

e052e0a

ALFMOB-272: Escape modern contextual keywords in generated identifiers

bf76a18

ALFMOB-272: Public TypographyStyle init, fail-fast on missing modes, …

0644136

…clear stale pulled JSON

ALFMOB-274: Delete non-token colors (blue/yellow/orange); retire Colo…

993f39b

…rs.xcassets

ALFMOB-274: Fix duplicate-ID ForEach warning in color demo (distinct …

7b8d344

…token ramps)

ALFMOB-274: Address Copilot review — drop Color.black/.white override…

f5f51c8

…, fix demo dupes, sync plan docs

ALFMOB-274: Clean up review nits — inline stale ThemedInput locals, c…

846876e

…onsistent demo Black swatch

Merge branch 'ALFMOB-272-design-token-codegen' into ALFMOB-274-integr…

1605e3b

…ate-color-tokens

ALFMOB-270: Source spacing & corner-radius from generated design tokens

eec1950

ALFMOB-270: Add plan, scope & grill docs for spacing & shape token in…

372ba46

…tegration

ALFMOB-270: Source corner radius from radius tokens (soft <10, strong…

d418aa4

… otherwise)

ALFMOB-270: Update plan & grill docs for radius-token sourcing decision

711cf8d

ALFMOB-270: Consolidate CornerRadius to none/soft/strong/rounded; mig…

f43c2d3

…rate call sites

ALFMOB-270: Document CornerRadius consolidation in plan

4139b3e

ALFMOB-270: Drop CornerRadius.none; radius API is now fully token-sou…

1e9059f

…rced

ALFMOB-270: Delete CornerRadius alias; use Sizing.radius* tokens dire…

5373739

…ctly

ALFMOB-270: Delete Spacing enum; use Primitives.Spacing tokens directly

5706314

ALFMOB-270: Add DesignSystem aggregator (color/spacing/radius/font/sh…

0c14096

…ape) + Environment seam

ALFMOB-270: Drop shape from DesignSystem (not a token); use Unavailab…

807a8f3

…leCrossedOutShape directly

ALFMOB-270: Document radius-rounded pill convention (1000pt from gene…

add5220

…rated token)

ALFMOB-270: Fix stale DesignSystem doc comment (shape removed)

a2ccd58

ALFMOB-270: Drop provider protocols; concrete let providers on Design…

e08549d

…System

khoinguyen-mindera added 6 commits June 29, 2026 15:27

ALFMOB-266: Add dev-2 DebugMenu migration handoff notes

2228f75

merge: dev-1 SharedUI typography migration

db16568

merge: dev-2 DebugMenu typography migration

59cc475

merge: dev-3 feature-module typography migration

985a7f7

ALFMOB-266: Remove legacy typography system; fix demo body clash + to…

d59947a

…ken test

ALFMOB-266: Fix stale test comment; mark plan completed

c7b2576

Copilot AI review requested due to automatic review settings June 29, 2026 09:02

Copilot started reviewing on behalf of khoinguyen-mindera June 29, 2026 09:03 View session

Copilot AI reviewed Jun 29, 2026

View reviewed changes

khoinguyen-mindera added 2 commits June 29, 2026 16:54

ALFMOB-266: Address review — concrete typography sub-providers; kerni…

b48b6bc

…ng/lineHeight tests; collapse dead switch

ALFMOB-266: Address Copilot — brand-font system fallback; fix Undefin…

f6b8de4

…ied/Mesure typos

khoinguyen-mindera requested a review from Copilot June 30, 2026 02:53

Copilot started reviewing on behalf of khoinguyen-mindera June 30, 2026 02:54 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread Alfie/AlfieKit/Sources/SharedUI/Theme/Typography/TypographyProvider.swift

Comment thread Alfie/AlfieKit/Sources/SharedUI/Theme/Typography/Specifications/TypographyGroups.swift Outdated

khoinguyen-mindera changed the base branch from main to ALFMOB-270-integrate-spacing-shape-tokens June 30, 2026 07:27

khoinguyen-mindera added 4 commits June 30, 2026 15:07

khoinguyen-mindera force-pushed the ALFMOB-270-integrate-spacing-shape-tokens branch from 7177d70 to eb29256 Compare July 1, 2026 09:51

Base automatically changed from ALFMOB-270-integrate-spacing-shape-tokens to main July 1, 2026 12:40

khoinguyen-mindera requested a review from Copilot July 1, 2026 15:45

Copilot started reviewing on behalf of khoinguyen-mindera July 1, 2026 15:45 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread Alfie/AlfieKit/Tests/SharedUITests/Typography/TypographyProviderTokenTests.swift

Comment thread Alfie/AlfieKit/Sources/SharedUI/Theme/Typography/TypographyProvider.swift

ALFMOB-266: Address Copilot re-review — injectable typography groups;…

24df130

… assert all token fields

khoinguyen-mindera requested a review from Copilot July 2, 2026 02:31

Copilot started reviewing on behalf of khoinguyen-mindera July 2, 2026 02:31 View session

Copilot AI reviewed Jul 2, 2026

View reviewed changes

amccall-mindera approved these changes Jul 2, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ALFMOB-266: Integrate typography tokens (Figma-named provider + full call-site migration)#87

ALFMOB-266: Integrate typography tokens (Figma-named provider + full call-site migration)#87
khoinguyen-mindera wants to merge 54 commits into
mainfrom
ALFMOB-266-integrate-typography-tokens

khoinguyen-mindera commented Jun 29, 2026 •

edited by atlassian Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

amccall-mindera left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

khoinguyen-mindera commented Jun 29, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ALFMOB-266 — Integrate typography tokens from design token JSON

What & why

Changes

Token mapping (legacy → Figma)

⚠️ Expected visual changes (accepted)

Verification

Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

amccall-mindera left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

khoinguyen-mindera commented Jun 29, 2026 •

edited by atlassian Bot

Loading