2603 add a clear button on the search component#2624
Open
rukundo-kevin wants to merge 23 commits into
Open
Conversation
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.88.1 to 1.88.2. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.88.1...v1.88.2) --- updated-dependencies: - dependency-name: rubocop dependency-version: 1.88.2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [pagy](https://github.com/ddnexus/pagy) from 43.5.6 to 43.6.0. - [Release notes](https://github.com/ddnexus/pagy/releases) - [Changelog](https://github.com/ddnexus/pagy/blob/master/docs/CHANGELOG.md) - [Commits](ddnexus/pagy@43.5.6...43.6.0) --- updated-dependencies: - dependency-name: pagy dependency-version: 43.6.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [excon](https://github.com/excon/excon) from 1.4.2 to 1.5.0. - [Changelog](https://github.com/excon/excon/blob/master/changelog.txt) - [Commits](excon/excon@v1.4.2...v1.5.0) --- updated-dependencies: - dependency-name: excon dependency-version: 1.5.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
--- updated-dependencies: - dependency-name: rubocop-rails dependency-version: 2.36.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
--- updated-dependencies: - dependency-name: selenium-webdriver dependency-version: 4.46.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
KralMarko123
left a comment
KralMarko123
left a comment
Collaborator
There was a problem hiding this comment.
This looks good, tested it out and works perfectly. Just remove the changes you've made to Gemfile.lock if they aren't needed for the component actually. Also, add your changes to the CHANGELOG. Let me know when you've made the changes and I'll approve the PR
…88.2 chore(deps-dev): bump rubocop from 1.88.1 to 1.88.2
chore(deps): bump pagy from 43.5.6 to 43.6.0
chore(deps): bump excon from 1.4.2 to 1.5.0
…ils-2.36.0 chore(deps-dev): bump rubocop-rails from 2.35.5 to 2.36.0
…ebdriver-4.46.0 chore(deps-dev): bump selenium-webdriver from 4.45.0 to 4.46.0
Bumps [mini_magick](https://github.com/minimagick/minimagick) from 5.3.1 to 5.3.2. - [Release notes](https://github.com/minimagick/minimagick/releases) - [Commits](minimagick/minimagick@v5.3.1...v5.3.2) --- updated-dependencies: - dependency-name: mini_magick dependency-version: 5.3.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…k-5.3.2 chore(deps): bump mini_magick from 5.3.1 to 5.3.2
…hub.com:MindLeaps/tracker into 2603-add-a-clear-button-on-the-search-component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.