Fix summary for Folder Scan output. Bug with "Policy-relevant binarie…#536
Open
chlaplan wants to merge 1 commit into
Open
Fix summary for Folder Scan output. Bug with "Policy-relevant binarie…#536chlaplan wants to merge 1 commit into
chlaplan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#535
This pull request significantly improves the accuracy and diagnostic value of folder scan reporting in the WDAC Policy Wizard. The main enhancements include more precise counting of policy-relevant binaries, detailed classification and logging of hash rule "flavors" emitted per binary, and improved terminology for duplicate hashes. These changes help clarify the relationship between scanned files and generated hash rules, making it easier to diagnose issues and understand policy outputs.
Scan statistics and reporting improvements:
FriendlyNamevalues) rather than simply counting hash rules, providing a more accurate representation of distinct files scanned. [1] [2]Hash rule flavor analysis and logging:
FriendlyName, with robust handling for future variations. [1] [2]Code structure and maintainability:
FolderScanStatsclass, improving code clarity and maintainability.Dependency and import updates:
System.LinqandSystem.Text.RegularExpressionsimports to support new logic for flavor parsing and breakdown reporting.