fix: resolve assigned security issues#559
Open
oche11207-art wants to merge 2 commits into
Open
Conversation
Issue MettaChain#453 (P1): PropertyCard - remove nested interactive elements - Replace outer <Link> with <article> to fix nested-interactive violation - Add explicit <Link> for property title and View button - Remove stopPropagation calls (no longer needed without parent link) - Update a11y tests to match new DOM structure Issue MettaChain#454 (P3): ViewToggle - add accessible names - Add aria-labels to grid/list buttons for screen-reader support - Wrap text in <span> for icon-only rendering scenarios Issue MettaChain#451 (P2): Share URL security - Create centralized share URL utility with URL validation - Sanitize display strings to constrained character set - Use URL constructor to validate all URLs - Integrate into ShareButton and MortgageCalculator Issue MettaChain#452 (P2): Global listener leak prevention - Add cleanup functions for extension event listeners - Track console overrides for restoration on cleanup - Create usePerformanceMonitoring hook with lifecycle management
- MettaChain#448: deviceId stored unencrypted in localStorage - use per-session in-memory ID - MettaChain#442: Chainalysis API key exposed via window global - proxy API route - MettaChain#439: chart.tsx dangerouslySetInnerHTML - sanitize with DOMPurify - MettaChain#431: batchTransaction confirmation races - viem provider reads + DEMO flag
Contributor
nanaf6203-bit
requested changes
Jun 29, 2026
nanaf6203-bit
left a comment
Contributor
There was a problem hiding this comment.
Thanks @oche11207-art — strong set of fixes covering #448, #442, #439, #431. Solid work on deviceId, Chainalysis, ChartStyle, and batch-tx. This branch has merge conflicts against current main though. Please rebase and resolve before we can land it. 🔒
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #448, #442, #439, #431
Changes
#448 - deviceId stored unencrypted in localStorage
#442 - Chainalysis API key exposed via window global
#439 - chart.tsx uses dangerouslySetInnerHTML for SVG payload
#431 - batchTransaction confirmation logic races simulation branches
Testing