chore(deps): upgrade class-validator to v0.15.1 (closes #759)#861
Open
dzekojohn4 wants to merge 1 commit into
Open
chore(deps): upgrade class-validator to v0.15.1 (closes #759)#861dzekojohn4 wants to merge 1 commit into
dzekojohn4 wants to merge 1 commit into
Conversation
- class-validator: ^0.14.1 -> ^0.15.1; class-transformer ^0.5.1 unchanged (still compatible) - Mostly additions in v0.15; validateNested() is stricter but every @ValidateNested site (4 total) already has its @type paired, so no source-code change required - Audit on the 8 @type(() => Date) sites - all left unchanged because the global ValidationPipe uses transform: true + enableImplicitConversion: true (src/main.ts), and v0.15's stricter IsDate semantics are satisfied - Validation: tsc clean, full test suite 34 suites / 224 tests / 0 failures (2 skipped, unchanged) - Working tree clean: no unrelated lint --fix style edits included
|
@dzekojohn4 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #759
Closes #760
Closes #761
Closes #762
Audit performed
@type(() => Date) (8 sites, all reviewed):
Left unchanged. v0.15's stricter IsDate handling is compatible with the global ValidationPipe config (src/main.ts): transform: true + transformOptions.enableImplicitConversion: true. enableImplicitConversion delegates native primitive coercion to class-transformer, and v0.15's stricter Date-string validation continues to reject malformed ISO strings.
@ValidateNested (4 sites, all reviewed):
All four are already correctly paired with @type, which is the contract v0.15 enforces strictly. No source changes required.
Validation
Semver note
^0.15.1 allows future 0.15.x patches but blocks 0.16.0 - appropriate for a dep where minor versions historically introduce semantic changes.