🎨 Palette: Improve profile search UX and accessibility#391
Conversation
Co-authored-by: yeboster <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Made the search clear button conditionally render only when there is text in the search input, updated the reactive filter to reset when empty, and improved the clear button ARIA label.
🎯 Why: When the input is empty, the "cancel" button does nothing but is still focusable, creating extra stops for keyboard users. Additionally, deleting text back to empty did not reset the table filter.
📸 Before/After: Before, an empty search field showed a clear icon and could not be cleared by backspacing. After, the clear icon only appears when text is present, and backspacing to empty resets the list correctly.
♿ Accessibility: Added conditional rendering to remove the empty clear button from the tab sequence, and updated the
aria-labelfrom generic "cancel" to specific "clear search".PR created automatically by Jules for task 13109927249605347717 started by @yeboster