🎨 Palette: Conditionally render search clear icon and fix filter reset#387
🎨 Palette: Conditionally render search clear icon and fix filter reset#387yeboster wants to merge 1 commit into
Conversation
- Conditionally render the 'clear' trailing icon in the profile search text field so it isn't focusable when empty. - Change the aria-label of the clear icon from a generic 'cancel' to a more descriptive 'clear search'. - Fix the reactivity of the domain filter so it resets to the full list when the search input becomes empty. Co-authored-by: yeboster <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
💡 What:
Textfieldinsrc/routes/profile/+page.svelteto conditionally render its trailing 'clear' icon only when there is text in the search input.aria-labelfrom "cancel" to "clear search".domainsFilteredarray back to the full list of domains.🎯 Why:
Previously, the clear button was always present in the DOM. Even if the search input was empty (meaning there was nothing to clear), the button could still be reached via keyboard navigation (tabbing), which is confusing for screen reader users and keyboard navigators. Additionally, the label "cancel" is ambiguous; "clear search" explicitly states the button's purpose. Finally, clearing the search input via keyboard backspaces left the filtered list stuck on the results of the last typed character, preventing users from easily viewing all their domains without refreshing.
♿ Accessibility:
aria-labelis much more descriptive ("clear search" vs "cancel").withTrailingIconis bound to the same condition.PR created automatically by Jules for task 8164934079318432726 started by @yeboster