⚡ Bolt: [performance improvement]

.jules/bolt.md

@@ -9,3 +9,8 @@
 
 **Learning:** Using `on:keyup` for search input debouncing triggers unnecessary API calls on navigation keys (arrows, home, end) and misses changes from paste/cut. Svelte's reactive statements `$: debounce(value)` provide a robust, declarative way to trigger debouncing only when the value actually changes.
 **Action:** Replace `on:keyup` handlers with reactive statements for input debouncing to improve performance and correctness.
+
+## 2024-05-24 - Array Intersection Complexity
+
+**Learning:** When filtering or comparing elements between two potentially large arrays (e.g., `owners.filter(owner => !voters.includes(owner))`), `Array.prototype.includes()` nested inside an array iteration method creates O(N\*M) time complexity.
+**Action:** Always convert the second array to a `Set` before the loop (e.g., `const votersSet = new Set(voters)`) to enable O(1) lookups via `Set.prototype.has()`, reducing the overall time complexity to O(N+M).

src/routes/api/proposals/voters/add/+server.ts

@@ -23,7 +23,9 @@ export async function GET() {
 			?.setValue()
 			.values.map((voter) => voter.addressValue().value.toString('hex')) ?? [];
 
-	const newVoters = owners.filter((owner) => !voters.includes(owner)).slice(0, 50);
+	// ⚡ Bolt: Optimize large array intersection by precomputing a Set for O(1) lookups instead of O(N) .includes()
+	const votersSet = new Set(voters);
+	const newVoters = owners.filter((owner) => !votersSet.has(owner)).slice(0, 50);
 	if (newVoters.length === 0) return json({ newVoters }, { status: 200 });
 
 	const votingContract = await metaNamesSdk.contractRepository.getContract({

src/routes/api/proposals/voters/remove/+server.ts

@@ -25,7 +25,9 @@ export async function GET() {
 			?.setValue()
 			.values.map((voter) => voter.addressValue().value.toString('hex')) ?? [];
 
-	const votersToRemove = voters.filter((voter) => !owners.includes(voter)).slice(0, 50);
+	// ⚡ Bolt: Optimize large array intersection by precomputing a Set for O(1) lookups instead of O(N) .includes()
+	const ownersSet = new Set(owners);
+	const votersToRemove = voters.filter((voter) => !ownersSet.has(voter)).slice(0, 50);
 	if (votersToRemove.length === 0) return json({ newVoters: votersToRemove }, { status: 200 });
 
 	const votingContract = await metaNamesSdk.contractRepository.getContract({