feat: support passing proxy_protocol to reality backend#2693
Open
aJC7737 wants to merge 1 commit into
Open
Conversation
46220ad to
e0a42d4
Compare
Author
|
Follow-up update for this PR: Since the previous revision, I added a few safety/completeness improvements around the new Reality Newly added changes
Current status summaryThis PR adds Behavior
Implementation
Scope
Test status
This should make the feature safer and easier to reason about in edge cases. |
61b8d7f to
17bed79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: This change adds
proxy-protocolsupport to Reality inbound so backends (for example NGINX) can see the original client source address.What This PR Adds
New Reality inbound option:
proxy-protocol0: disabled (default)1: send PROXY protocol v1 header2: send PROXY protocol v2 headerPROXY header forwarding for Reality backend connections
ProxyProtocolto Reality runtime config.0/1/2).Source/destination address propagation
PROXY protocol encoding support
Documentation updates
reality-config.proxy-protocolexamples in config documentation.Tests
Added/updated unit tests covering:
proxy-protocol = 0, no header emitted)Scope