Harden price-backfill against transient fetch failures#17
Merged
Conversation
A clean (non-redeploy) full run left ~11% of items as fetch-failed — transient HTTP/network errors under sustained load, not a data gap. Raise _get retries 3->5 and add a bounded end-of-run re-sweep (--resweep-rounds, default 2) that re-fetches fetch-failed items until none remain, so a single run no longer needs a manual gentle salvage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A clean full run (no redeploy,
build_gen=0) still left ~11% of items asfetch-failed— transient HTTP/network errors that survived the per-request retries under sustained ~90-min load. These items just weren't reached; not corrupt data, but an incomplete run that needed a manual gentle re-fetch to salvage (happened on both the price run and the item-count run).Fix
wowauctions._getretries raised 3 -> 5 (exponential backoff unchanged).fetch-faileditems for--resweep-rounds(default 2) passes until none remain. Mirrors the existing redeploy-recovery structure; transient failures clear on a later attempt.Tests
43 passing, incl. a new
select_fetch_failedtest. README documents--resweep-roundsand the behavior.