Fix -Werror unused-parameter build break in AuctionHouseBot#12
Merged
Conversation
The core build uses -Werror -Wunused-parameter. getElement's botId and GetItemsToSell's botGuid are never used in their bodies (dedup keys on the botItemCounts map / _id member instead), producing a fatal build error. Unname both parameters following the module's existing convention.
-Wunused-variable is fatal under the core build. Remove dead locals in Buy() (guid) and Sell() (minAuctionsPerBot, maxStackSize, and the now-orphaned minTotalItems). All were assigned side-effect-free getters/arithmetic and never read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The core build fails (
-Werror -Wunused-parameter, clang-18):This is pre-existing (the flagged code dates to 2025-05-21) and became fatal with the stricter flags from the recent azerothcore master merge.
-ferror-limit=1only surfaces the first one; a scan of the module found a second identical case.Fix
Two named-but-unused parameters, unnamed following the module's own existing convention (see
AuctionHouseBotAuctionHouseScript.cpp, which already unnames unused hook params):AuctionHouseBot::getElement—uint32 botId(dedup keys on thebotItemCountsmap, notbotId)AuctionHouseBot::GetItemsToSell—ObjectGuid botGuid(body uses the_idmember instead)No behavior change; both parameters were already dead code.