ChromieCraft price backfill tool for AH-bot overrides#11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A standalone, zero-dependency Python tool (
tools/price-backfill/) that regeneratesdata/sql/db-world/2023_11_16_mod_auctionhousebot_priceOverride.sqlfrom ChromieCraft's live auction prices, filling the coverage gap where most AH-tradeable items currently fall back to fixed default pricing.How
acore_world.item_template(AH-tradeable filter:bonding IN (0,2,3),Quality <= 5, excl. quest/key classes)._next/dataJSON endpoint (queried by item ID only; browser UA; buildId resolved fresh, re-resolved on mid-run redeploy).avg_price→ avgPrice,minimum_buyout→ minPrice; floors both at vendor SellPrice; clamps min ≤ avg; configurablePRICE_SCALE(default 1.0).deviations.csv— a worst-first review worklist of every item whose new price differs ≥1.5× from the shipped override, so contested prices can be decided by hand.Robustness
fetch-failed/error), never silently dropped.Tests
cd tools/price-backfill && python3 -m unittest discover— 26 passing (stdlibunittest, no network in unit tests). Live smoke run verified end-to-end.Notes
git diff(anddeviations.csvwalked) before committing — it is not included in this PR. This PR is the tool, spec, and plan only.docs/superpowers/.