You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi!
Thanks for your contribution!
This is a good start for basic coverage, but it does not yet cover the main MemFeedback.process_feedback workflow. The PR currently tests config parsing, the abstract base class, and a few utility functions, while the core feedback processing path (_validate_feedback_data, _record_feedback, _analyze_feedback) and operation-specific branches remain untested. Could we add at least one mocked workflow test for process_feedback covering a valid feedback input and the expected downstream calls?
Thanks for the review. I added a mocked process_feedback workflow test that verifies a valid feedback input calls both _generate_answer and process_feedback_core, then returns the downstream memory record.
Verified locally:
uv run --with pytest pytest tests/mem_feedback -q -> 16 passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1696
Summary
tests/mem_feedbackpackage.Tests
uv run --python 3.12 --extra mem-reader --with pytest pytest tests/mem_feedback -quv run --python 3.12 --extra mem-reader --with pytest pytest tests/mem_feedback tests/mem_chat/test_base.py tests/mem_cube/test_base.py -quv run --python 3.12 --extra mem-reader --with ruff ruff check tests/mem_feedbackgit diff --checkNotes
devbase branch, but this repository currently exposesmainas the active/default base branch.