Skip to content

Mark library as AOT-compatible #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinKuschnik merged 4 commits into from
Apr 3, 2026
Merged

Mark library as AOT-compatible #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e162183
Mark library as AOT-compatible
ocoanet Apr 3, 2026
deaa985
Update AOT and trimming config
MartinKuschnik Apr 3, 2026
82f053b
Bump version to 7.1.1
MartinKuschnik Apr 3, 2026
d015475
Fix build for external PRs by conditionally disabling assembly signing
MartinKuschnik Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ env:
# You can convert this to a build matrix if you need coverage of multiple configuration types.
# https://docs.github.com/actions/learn-github-actions/managing-complex-workflows#using-a-build-matrix
BUILD_CONFIGURATION: Release
# Disable assembly signing for pull requests because GitHub secrets are not available for PRs from forks.
# This allows external contributors to successfully build the project without access to the private key.
SIGN_ASSEMBLY: ${{ github.event_name != 'pull_request' }}

jobs:
build:
Expand All @@ -32,15 +35,17 @@ jobs:
run: dotnet restore

- name: Extract Private Key
if: ${{ env.SIGN_ASSEMBLY == 'true' }}
run: |
echo "${{ secrets.PRIVATE_KEY }}" > WmiLight\private_key.base64
certutil -decode WmiLight\private_key.base64 WmiLight\private_key.snk
rm WmiLight\private_key.base64

- name: Build .Net Lib
run: msbuild /m /p:Configuration=${{env.BUILD_CONFIGURATION}} /p:Platform=AnyCPU WmiLight\WmiLight.csproj
run: msbuild /m /p:Configuration=${{env.BUILD_CONFIGURATION}} /p:Platform=AnyCPU /p:SignAssembly=${{env.SIGN_ASSEMBLY}} WmiLight\WmiLight.csproj

- name: Cleanup Private Key
if: ${{ env.SIGN_ASSEMBLY == 'true' }}
run: rm WmiLight\private_key.snk

- name: Build Native dynamic Lib (x64)
Expand Down
8 changes: 4 additions & 4 deletions WmiLight.Native/WmiLight.Native.rc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ END
//

VS_VERSION_INFO VERSIONINFO
FILEVERSION 7,1,0,0
PRODUCTVERSION 7,1,0,0
FILEVERSION 7,1,1,0
PRODUCTVERSION 7,1,1,0
FILEFLAGSMASK 0x3fL
#ifdef _DEBUG
FILEFLAGS 0x1L
Expand All @@ -70,12 +70,12 @@ BEGIN
VALUE "FileDescription", "The native part of the WmiLight lib."
#endif

VALUE "FileVersion", "7.1.0.0"
VALUE "FileVersion", "7.1.1.0"
VALUE "InternalName", "WmiLight.Native"
VALUE "LegalCopyright", "Copyright 2026 Martin Kuschnik"
VALUE "OriginalFilename", "WmiLight.Native.dll"
VALUE "ProductName", "WmiLight"
VALUE "ProductVersion", "7.1.0.0"
VALUE "ProductVersion", "7.1.1.0"
END
END
BLOCK "VarFileInfo"
Expand Down
1 change: 1 addition & 0 deletions WmiLight.TestApp-NetCore/WmiLight.TestApp-NetCore.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<RootNamespace>WmiLight.TestApp_NetCore</RootNamespace>
<Platforms>x64;x86;ARM64</Platforms>
<PublishAot>True</PublishAot>
<VerifyReferenceAotCompatibility>true</VerifyReferenceAotCompatibility>
</PropertyGroup>

<ItemGroup>
Expand Down
14 changes: 7 additions & 7 deletions WmiLight/WmiLight.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,20 @@
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<DocumentationFile>bin\Release\WmiLight.xml</DocumentationFile>
<AssemblyOriginatorKeyFile>private_key.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<SignAssembly>True</SignAssembly>
<AssemblyOriginatorKeyFile>private_key.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>
<PropertyGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0')) Or $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net9.0'))">
<!-- net8.0 or later is required for AOT analysis support -->
<PropertyGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))">
<IsTrimmable>true</IsTrimmable>
<IsAotCompatible>true</IsAotCompatible>
<VerifyReferenceAotCompatibility>true</VerifyReferenceAotCompatibility>
</PropertyGroup>
<Target Name="AfterBuild" />
<Target Name="AfterClean">
</Target>
<PropertyGroup />
<PropertyGroup>
<Version>7.1.0</Version>
<Version>7.1.1</Version>
<PackageId>WmiLight</PackageId>
<Authors>Martin Kuschnik</Authors>
<Company>Martin Kuschnik</Company>
Expand All @@ -42,7 +42,7 @@
<!-- Workaround for https://github.com/dotnet/sdk/issues/43016. -->
<_NeedToDownloadMicrosoftNetSdkCompilersToolsetPackage>true</_NeedToDownloadMicrosoftNetSdkCompilersToolsetPackage>

<FileVersion>7.1.0</FileVersion>
<FileVersion>7.1.1</FileVersion>
<AllowUnsafeBlocks>True</AllowUnsafeBlocks>

</PropertyGroup>
Expand Down
Loading