Fix arrows3d component alignment under non-uniform scaling - #5742
Open
Cedriq1astaken wants to merge 3 commits into
Open
Fix arrows3d component alignment under non-uniform scaling#5742Cedriq1astaken wants to merge 3 commits into
Cedriq1astaken wants to merge 3 commits into
Conversation
ffreyer
self-requested a review
August 15, 2026 09:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5711
When we set
normalize = truewhen usingarrows3d, there was an issue where the components (tail, shaft, tip) were misaligned when transformed (this doesn't occur when usingLScenesince the model matrix is simply the identity matrix). The issue occurred because the code assumed that the directions passed to the positioning step would already be normalized.(before)

The fix is to remove this assumption and always normalize the directions before positioning the components.
(after fix)

Type of change
Checklist