Skip to content

Fix arrows3d component alignment under non-uniform scaling - #5742

Open
Cedriq1astaken wants to merge 3 commits into
MakieOrg:masterfrom
Cedriq1astaken:issue_5711
Open

Fix arrows3d component alignment under non-uniform scaling#5742
Cedriq1astaken wants to merge 3 commits into
MakieOrg:masterfrom
Cedriq1astaken:issue_5711

Conversation

@Cedriq1astaken

Copy link
Copy Markdown
Contributor

Description

Fixes #5711

When we set normalize = true when using arrows3d, there was an issue where the components (tail, shaft, tip) were misaligned when transformed (this doesn't occur when using LScene since the model matrix is simply the identity matrix). The issue occurred because the code assumed that the directions passed to the positioning step would already be normalized.

(before)
image

The fix is to remove this assumption and always normalize the directions before positioning the components.

(after fix)
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@github-project-automation github-project-automation Bot moved this to Work in progress in PR review Aug 13, 2026
@Cedriq1astaken Cedriq1astaken changed the title Issue 5711 Fix arrows3d component alignment under non-uniform scaling Aug 13, 2026
@ffreyer
ffreyer self-requested a review August 15, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Work in progress

Development

Successfully merging this pull request may close these issues.

arrows3d arrow tip drawn mid-shaft when normalize=true

1 participant