Refactor XML Parser & XML Generation#223
Merged
EmmasBox merged 3 commits intoMar 20, 2026
Merged
Conversation
Collaborator
Author
|
Before : Summary link
After : Summary link
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Issue Reference
Issue: #214
💻 What does this address?
This PR focuses on modernizing the XML Generation and Parser logic. The primary goals were to replace brittle conditional logic with efficient lookups and to standardize string handling across the codebase.
📟 Implementation Details
Logic Modernization: Refactored
XMLGeneratorto usestd::unordered_mapfor administrative type and operation mappings, replacing long if/else chains. This improves maintainability and lookup performance.Standardized String Handling: Updated both
xml_generator.cppandxml_parser.cppto consistently usestd::string. This eliminates manual memory management and improves safety during conversions.Function Cleanup: Streamlined the core functions in
XMLGeneratorto be more modular and readable. Specifically:Added a checkout step to the Labeler workflow to prevent
The configuration file (path: .github/labeler.yml) was not found locally, fetching via the apiin job log.