Align Python Search Tests with search return codes#216
Closed
yinjie-z wants to merge 1 commit into
Closed
Conversation
github-actions
Bot
added
the
tests
yinjie-z
force-pushed
the
fix/python-return-codes
branch
from
2cb9f71 to
fdc1317
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Python unit test suite to differentiate between a successful data retrieval (0,0,0,0) and a successful empty result (4,4,4,0).
Previously, all successful searches were asserting against a hardcoded 4,4,4 state. Following the core logic update, searches that return profiles now provide a standard success code.
Changes
Updated Assertions: Refactored
test_search_resource_profiles_nonexistent_class,test_search_resource_profiles_allandtest_search_resource_profiles_filterto use the correct return code constants based on whether profiles are expected.successful_return_codeswhen the result list contains profiles.empty_return_codes_searchwhen the result list is empty.Need to run the tests in zos before merging
Ref #215