Added special handling for search tokens beginning with @#857
Open
smallsaucepan wants to merge 1 commit into
Open
Added special handling for search tokens beginning with @#857smallsaucepan wants to merge 1 commit into
smallsaucepan wants to merge 1 commit into
Conversation
double quoting before passing to mysql stops @whatever being mistaken for a fulltext search proximity operator. Resolves MLTSHP#606
bradchoate
reviewed
Dec 22, 2025
| # quotes first. | ||
| # More info: @distance fulltext search proximity operator | ||
| # https://dev.mysql.com/doc/refman/8.4/en/fulltext-boolean.html | ||
| q = re.sub(r'(?<!")(\B@[\w\-]+)(?!")', r'"\1"', q) |
Collaborator
There was a problem hiding this comment.
Can this be done in lib.utilities.clean_search_term?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implicitly double quoting before passing to mysql stops
@whateverbeing mistaken for a fulltext search proximity operator.Resolves #606